Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add extra parameter to 08-wasm NewKeeper function to take in authority address #3990

Closed
crodriguezvega opened this issue Jun 30, 2023 · 1 comment
Closed

Add extra parameter to 08-wasm NewKeeper function to take in authority address #3990

crodriguezvega opened this issue Jun 30, 2023 · 1 comment
Labels
08-wasm type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.
Milestone
08-wasm/v0.1.0

Comments

@crodriguezvega
Copy link
Contributor

crodriguezvega commented Jun 30, 2023 •
edited
Loading

Surfaced from Interchain IBC team's review of 08-wasm at hash https://github.com/strangelove-ventures/ibc-go/commit/96e9930ab87a171a3ae6ac9717ee25bfda77212b

Instead of hard-coding the authority to the governance module address, add an extra parameter to NewKeeper.
@crodriguezvega crodriguezvega added type: refactor Architecture, code or CI improvements that may or may not tackle technical debt. 08-wasm labels Jun 30, 2023
@crodriguezvega crodriguezvega added this to the 08-wasm/v1.0.0 milestone Jun 30, 2023
@Reecepbcups Reecepbcups mentioned this issue Jul 15, 2023
Merged
9 tasks
@crodriguezvega
Copy link
Contributor Author

Closed by #4092

@github-project-automation github-project-automation bot moved this to Done in ibc-go Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
08-wasm type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.
Projects
ibc-go
Status: Done 🥳
Milestone
08-wasm/v0.1.0
Development

No branches or pull requests
1 participant
@crodriguezvega