Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify sane default for default upgrade timeout timestamp #4513

Closed
3 tasks
chatton opened this issue Aug 30, 2023 · 1 comment
Closed
3 tasks

Specify sane default for default upgrade timeout timestamp #4513

chatton opened this issue Aug 30, 2023 · 1 comment
Assignees
Labels
04-channel channel-upgradability Channel upgradability feature

Comments

@chatton
Copy link
Contributor

chatton commented Aug 30, 2023

Summary

We're currently hardcoding 1 hour as a default timeout for channel upgrades. We need to decide on a sane default for this value.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@womensrights
Copy link
Contributor

My recommendation for the default time is 10 minutes.

Feedback from relayer operators has indicated that under typical conditions, where you might typically have a packet backlog between 1-10 packets, then flushing would take a few seconds, therefore 10 minutes is already relatively conservative, but is in line with existing defaults.

The only scenario to consider more carefully is the case where flushing would require an archival node to complete and packets are still in the channel that have not been timed-out for quite some time. I don't think it makes sense to cater for this edge case where the flushing process would take much longer, instead we should recommend that a chain should not start the governance process for upgrading that specific channel and this should be made clear in the accompanying documentation and tutorial for adding fee middleware to existing channels.

@damiannolan damiannolan self-assigned this Dec 18, 2023
@damiannolan damiannolan moved this from Todo to In progress in ibc-go Dec 18, 2023
@github-project-automation github-project-automation bot moved this from In progress to Done in ibc-go Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
04-channel channel-upgradability Channel upgradability feature
Projects
Archived in project
Development

No branches or pull requests

4 participants