Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove InitModule function in interchain accounts #4639

Closed
3 tasks
colin-axner opened this issue Sep 12, 2023 · 3 comments · Fixed by #4977
Closed
3 tasks

Remove InitModule function in interchain accounts #4639

colin-axner opened this issue Sep 12, 2023 · 3 comments · Fixed by #4977

Comments

@colin-axner
Copy link
Contributor

Summary

The InitModule function was added in interchain accounts as an alternative to InitGenesis during in place upgrades to allow app developers to set their custom params. However, the same logic can be achieved by setting the desired params directly after calling mm.RunMigrations, we should remove the InitModule function and update docs to indicate this behaviour.

This should ease ica integration as no custom init function needs to be called and it eases our maintence burden as there is no longer a function mimicing InitGenesis


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@damiannolan
Copy link
Member

💯

@muku314115
Copy link
Contributor

Should this be recorded in the v7.3.x migration docs directly?

@crodriguezvega
Copy link
Contributor

Should this be recorded in the v7.3.x migration docs directly?

I don't think we should back port this change to v7.3.x, since a function that is part of the public API is removed, so that would be an API-breaking change. Therefore, mostly likely this change will be released in v9, so you could add a v8-to-v9.md migration file already, if you would like to. Otherwise we can do document this in the v9 migration docs ourselves later on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done 🥳
Development

Successfully merging a pull request may close this issue.

4 participants