Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup OnAcknowledgement and OnTimeout code #863

Closed
AdityaSripal opened this issue Feb 7, 2022 · 0 comments · Fixed by #1228
Closed

Cleanup OnAcknowledgement and OnTimeout code #863

AdityaSripal opened this issue Feb 7, 2022 · 0 comments · Fixed by #1228
Assignees
@damiannolan
Labels
29-fee
Milestone
Fee middleware beta

Comments

@AdityaSripal
Copy link
Member

Call underlying app's OnAcknowledgement and OnTimeout only once, and move the fee escrow logic into an if statement only when fee is found for the given packet.

https://github.com/cosmos/ibc-go/blob/13f77de949/modules/apps/29-fee/ibc_module.go#L219

https://github.com/cosmos/ibc-go/blob/13f77de949/modules/apps/29-fee/ibc_module.go#L244
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@damiannolan damiannolan

Labels
29-fee
Projects
ibc-go
Archived in project
Milestone
Fee middleware beta
Development

Successfully merging a pull request may close this issue.

chore: cleanup OnAcknowledgement and OnTimeout code cosmos/ibc-go
3 participants
@damiannolan @crodriguezvega @AdityaSripal