Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring back confio/ICS23 #9

Closed
5 tasks done
adizere opened this issue Apr 26, 2021 · 0 comments
Closed
5 tasks done

Bring back confio/ICS23 #9

adizere opened this issue Apr 26, 2021 · 0 comments

Comments

@adizere
Copy link
Contributor

adizere commented Apr 26, 2021 •
edited
Loading

Crate

ibc mostly

Summary

The confio/ics23 dependency raised a cargo audit issue some time ago. We removed this dependency because we could temporarily avoid relying on it.

Now this dep. is no longer a security vulnerability, so we should bring it back.

Problem Definition

We currently have hardcoded proof specs in ibc

https://github.com/informalsystems/ibc-rs/blob/9f2c7cb67b89d4597ba4b7800fec1b44dfb88329/modules/src/ics23_commitment/merkle.rs#L22

We can import these specs nicely from confio/ics23 instead.

Acceptance Criteria

  • bring back the ics23 dependency,
  • replace our hardcoded proof specs with the "canonical ones" from confio/ics23.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@adizere