Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Most handlers emit events with the wrong height #52

Closed
5 tasks
plafer opened this issue Mar 29, 2022 · 0 comments
Closed
5 tasks

Most handlers emit events with the wrong height #52

plafer opened this issue Mar 29, 2022 · 0 comments
Labels
A: bug Admin: something isn't working

Comments

@plafer
Copy link
Contributor

plafer commented Mar 29, 2022 •
edited
Loading

Summary of Bug

modules::src::core::ics04_channel::handler::send_packet::process emits a IbcEvent::SendPacket event with height packet.timeout_height.

Other handlers, such as chan_open_try, emit an event with height zero.

Related to informalsystems/hermes#1009.

Version

v0.13.0

Acceptance Criteria

Event height is the height as taken from ChannelReader::host_height().

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@plafer plafer changed the title send_packet emits events with height as "timeout height" most handlers emit event with the wrong height Mar 30, 2022
@plafer plafer changed the title most handlers emit event with the wrong height most handlers emit events with the wrong height Mar 30, 2022
@romac romac changed the title most handlers emit events with the wrong height Most handlers emit events with the wrong height Mar 31, 2022
@romac romac added the A: bug Admin: something isn't working label Mar 31, 2022
@plafer plafer mentioned this issue Mar 31, 2022
Merged
6 tasks
@hu55a1n1 hu55a1n1 transferred this issue from informalsystems/hermes Sep 29, 2022
livelybug referenced this issue in octopus-network/ibc-rs Oct 14, 2022
@DaviRain-Su
Enable Event CreateClient (#52)
90a1973 
Update build create-client

Enable emit event

Remove something

Public Event UpgradeClient inner type

Public idenfitier clientId, connectionId, protId, channelId inner type

Add some log

Simple impl check_header_and_update_state

Add query latest_height for substrate node

for ConnectionInit

Add ics10_grandpa, with_header function

Add Event UpdateClient

Add query consensus_state with subxt rpc

fix success reveiver Event:

Add OpenAckConnection, and OpenConfirmConnection Event

Update Event Attributes for Connection

Co-authored-by: DaviRain-Su <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A: bug Admin: something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@romac @plafer