Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alter handshake to allow fixed/variable fields #462

Closed
cwgoes opened this issue Aug 4, 2020 · 3 comments · Fixed by #482
Closed

Alter handshake to allow fixed/variable fields #462

cwgoes opened this issue Aug 4, 2020 · 3 comments · Fixed by #482
Assignees
@cwgoes
Labels
from-review Feedback / alterations from specification review. tao Transport, authentication, & ordering layer.
Milestone
IBC Specification...

Comments

@cwgoes
Copy link
Contributor

cwgoes commented Aug 4, 2020

At least remote identifier, version.

Then optimistic handshakes can fix fields, non-optimistic can leave variable, if identifiers are unimportant they can be auto-selected.
@cwgoes cwgoes added tao Transport, authentication, & ordering layer. from-review Feedback / alterations from specification review. labels Aug 4, 2020
@cwgoes cwgoes added this to the IBC Specification 1.0.0 milestone Aug 4, 2020
@cwgoes cwgoes self-assigned this Aug 4, 2020
This was referenced Aug 5, 2020
Closed
Merged
@ethanfrey
Copy link
Contributor

Please specify if this is for channel or connection handshakes, or both?

I see the link to connOpenTry issue, so I assume for connections. Funny, as I was just about to write up a similar issue for channels. But I'll make a new issue

@ethanfrey ethanfrey mentioned this issue Aug 10, 2020
Closed
@cwgoes
Copy link
Contributor Author

cwgoes commented Aug 10, 2020

No reason not to support it in both handshakes, I think.

@cwgoes cwgoes mentioned this issue Aug 12, 2020
Closed
@cwgoes
Copy link
Contributor Author

cwgoes commented Sep 13, 2020 •
edited
Loading

Ideally we could do this without additional fields... maybe a sentinel value of empty-string?

Seems like empty-string shouldn't really be a valid identifier or version in the usual case.

@cwgoes cwgoes mentioned this issue Sep 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cwgoes cwgoes

Labels
from-review Feedback / alterations from specification review. tao Transport, authentication, & ordering layer.
Projects
None yet
Milestone
IBC Specification 1.0.0
Development

Successfully merging a pull request may close this issue.

Flexible identifier selection cosmos/ibc
2 participants
@ethanfrey @cwgoes