Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No crossing hellos on opening handshake #291

Closed
mpoke opened this issue Aug 24, 2022 · 0 comments · Fixed by #323
Closed

No crossing hellos on opening handshake #291

mpoke opened this issue Aug 24, 2022 · 0 comments · Fixed by #323
Assignees
Labels
type: refactoring Code refactoring

Comments

@mpoke
Copy link
Contributor

mpoke commented Aug 24, 2022

In Interchain Security, the ChanOpenInit message must go to the consumer, i.e., the provider returns an error on any Init messages, see

return sdkerrors.Wrap(ccv.ErrInvalidChannelFlow, "channel handshake must be initiated by consumer chain")

As a result, it is not possible to have crossing hellos, which means that the provider must claim directly the channel capability in OnChanOpenTry, without needing to check if it already claimed the capability, see

// Module may have already claimed capability in OnChanOpenInit in the case of crossing hellos

@mpoke mpoke added the type: refactoring Code refactoring label Aug 24, 2022
@mpoke mpoke self-assigned this Sep 2, 2022
@mpoke mpoke closed this as completed in #323 Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: refactoring Code refactoring
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant