Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide whether the consumer can update ConsumerRedistributeFrac #81

Closed
mpoke opened this issue Apr 30, 2022 · 6 comments · Fixed by #102
Closed

Decide whether the consumer can update ConsumerRedistributeFrac #81

mpoke opened this issue Apr 30, 2022 · 6 comments · Fixed by #102
Assignees

Comments

@mpoke
Copy link
Contributor

mpoke commented Apr 30, 2022

Currently, ConsumerRedistributeFrac, i.e., the fraction of tokens allocated to the consumer redistribution address during distribution events, which means it could be modified by the consumer through governance. I'd argue that the consumer should not be able to change this parameter without the consent of the provider chain. Thus, for now, we should add this as a field of the CreateChildChainProposal. Later we could allow this to be change by submitting a TX to the provider or through an IBC packet.

After discussions, the preferred solution is to keep the ConsumerRedistributeFrac hardcoded in the consumer chain. As a result, the validators on the provider chain can check the value when auditing the consumer binary, and the consumer chain cannot update it through governance.

@mpoke
Copy link
Contributor Author

mpoke commented Apr 30, 2022

@okwme Do you think we need for the V1 release to enable the consumer chain to change the ConsumerRedistributeFrac after deployment?

@jtremback
Copy link
Contributor

IMO we should approach governance abilities on consumer chains with a whitelist approach, not a blacklist approach. The default consumer chain should have no or very few governance capabilities. Capabilities that get whitelisted can be debated during the consumer chain proposal vote. So, by default, the answer is that it should not be possible for consumer governance to update ConsumerRedistributeFrac

@jtremback
Copy link
Contributor

IMO you should update this issue to be "Make consumer chain governance whitelist"

@mpoke
Copy link
Contributor Author

mpoke commented May 2, 2022

I opened another issue regarding whitelisting consumer chain parameters (see #82). I still think though that ConsumerRedistributeFrac should be specified in the governance proposal since it is part of the contract between the provider and the consumer.

@mpoke mpoke added product and removed ccv-core labels May 10, 2022
@mpoke mpoke self-assigned this May 11, 2022
@mpoke
Copy link
Contributor Author

mpoke commented May 12, 2022

Solution: Hardcoded in the consumer chain code.

@mpoke mpoke assigned rigelrozanski and unassigned mpoke May 13, 2022
@mpoke mpoke added ccv-core and removed question labels May 13, 2022
@rigelrozanski
Copy link
Contributor

Agree that we should hardcode it so that providers need to sign off on the new binary, hence they'd also sign off on modified distribution amounts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants