Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add fr-FR support to locales (#582) #582

Merged
merged 1 commit into from
May 24, 2022
Merged

feat: add fr-FR support to locales (#582) #582

merged 1 commit into from
May 24, 2022

Conversation

Renardjojo
Copy link
Contributor

@Renardjojo Renardjojo commented May 23, 2022 •
edited
Loading

Description

Add local file for amazing french peoples 🌟 (use fr-FR to include it into _config file)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How has this been tested

  • I have run bash ./tools/deploy.sh --dry-run (at the root of the project) locally and passed
  • I have tested this feature in the browser

Test Configuration

  • Browser type & version:
  • Operating system: GitHub
  • Ruby version: ruby 3.1.2p20
  • Bundler version: 2.3.14
  • Jekyll version: 4.2.2

Checklist

  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@Renardjojo Renardjojo changed the title Added a locale file for french feat: add fr-FR support to locales (#582) May 23, 2022
cotes2020
cotes2020 approved these changes May 24, 2022
View reviewed changes
Copy link
Owner

@cotes2020 cotes2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@cotes2020 cotes2020 merged commit 94e8144 into cotes2020:master May 24, 2022
@ivan-penchev ivan-penchev mentioned this pull request Jun 13, 2022
Merged
linkliu pushed a commit to linkliu/game-tech-post-old that referenced this pull request Jun 20, 2022
@Renardjojo @linkliu
feat: add fr-FR support to locales (cotes2020#582)
3d7482f 
(cherry picked from commit 94e8144)
linkliu added a commit to linkliu/game-tech-post-old that referenced this pull request Jun 20, 2022
@linkliu
Revert "feat: add fr-FR support to locales (cotes2020#582)"
67e11e0 
This reverts commit 3d7482f.
linkliu pushed a commit to linkliu/game-tech-post-old that referenced this pull request Jun 20, 2022
@Renardjojo @linkliu
feat: add fr-FR support to locales (cotes2020#582)
3da095b 
(cherry picked from commit 94e8144)
dkbnz pushed a commit to dkbnz/jekyll-theme-chirpy that referenced this pull request Jul 12, 2022
@Renardjojo
feat: add fr-FR support to locales (cotes2020#582)
829e2ee
shihtiy-tw pushed a commit to shihtiy-tw/shihtiy-tw.github.io that referenced this pull request Nov 26, 2022
@Renardjojo @shihtiy-tw
feat: add fr-FR support to locales (cotes2020#582)
e57e5f0
sanjidnet pushed a commit to sanjidnet/sanjidnet.github.io that referenced this pull request Jan 9, 2023
@Renardjojo
feat: add fr-FR support to locales (cotes2020#582)
bbd5370
Ap3x pushed a commit to Ap3x/ap3x.github.com that referenced this pull request Feb 23, 2023
@Renardjojo
feat: add fr-FR support to locales (cotes2020#582)
2df1977
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cotes2020 cotes2020 cotes2020 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Renardjojo @cotes2020