New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.3.5 - AddDistributedCouchbaseCache doesn't register IDistributedCache to DI like the overload with a bucket-name does #112

Open

JonathanAtCenterEdge opened this issue Dec 5, 2023 · 1 comment

JonathanAtCenterEdge commented Dec 5, 2023 •

edited

Loading

Previously in 3.3.4 https://github.com/couchbaselabs/Couchbase.Extensions/blob/master/src/Couchbase.Extensions.Caching/CouchbaseCacheServiceCollectionExtensions.cs#L19 would add the IDistributedCache to the service collection with CouchbaseCache as it's implementation, that was changed in 3.3.5 3207279

https://github.com/couchbaselabs/Couchbase.Extensions/blob/master/src/Couchbase.Extensions.Caching/CouchbaseCacheServiceCollectionExtensions.cs#L48 that takes a bucket-name as it's first paramter DOES add IDistributedCache to the service collection with CouchbaseCache as it's implementation

This seems unintentional, and a major or minor change for what is supposed to be a patch version change

The text was updated successfully, but these errors were encountered:

jeffrymorris commented Feb 12, 2024 •

edited

Loading

@JonathanAtCenterEdge thanks for reporting the issue! That does look like an unintentional bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment