Removed unneeded imports. Checked-in module config #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why check in the module configuration? It turns out that IDEA does a bad job of importing plugin modules from source. In particular, it fails to recognize them as plugin modules at all, thinking instead that they're just plain Java. The consequence of this mis-identification is that the build configurations get messed up, making it impossible to build your plugin. The manual procedure to fix this mis-identification is cryptic, so there's a clear benefit to checking in the project files. Why would you not check in the module files? * Someone using a different IDE (for developping IDEA plugins???) * IDK?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why check in the module configuration? It turns out that IDEA does a bad job
of importing plugin modules from source. In particular, it fails to recognize
them as plugin modules at all, thinking instead that they're just plain Java.
The consequence of this mis-identification is that the build configurations get
messed up, making it impossible to build your plugin. The manual procedure to
fix this mis-identification is cryptic, so there's a clear benefit to checking
in the project files.
Why would you not check in the module files?
There is also a small bugfix in here: because the resources folder wasn't properly identified (again, because import-from-source is no good) the template creation actions broke. I've rebuilt the plugin and modified the now-checked-in module file includes the relevant resource-folder registration.