Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameter naming consistency. #8

Open
vincenzobaz opened this issue Dec 8, 2020 · 2 comments
Open

Parameter naming consistency. #8

vincenzobaz opened this issue Dec 8, 2020 · 2 comments

Comments

@vincenzobaz
Copy link
Contributor

vincenzobaz commented Dec 8, 2020 •
edited
Loading

coursera_autograder grade local accepts the arguments

  1. --timeout
  2. --mem-limit

while coursera_autograder upload accepts the arguments

  1. --grading-timeout
  2. --grader-memory-limit

For consistency, the two commands should use the same names. The same goes for grading vs grader
@sashi-coursera
Copy link
Contributor

Thank you @vincenzobaz for this. We will address this soon. Also, you are welcome to provide a PR. We will review soon.

@echuber2
Copy link
Contributor

I'd recommend changing the upload options to match the shorter grade local options, which also makes the difference between grading and grader irrelevant. (Maybe leaving the existing upload options as deprecated alternatives.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@echuber2 @vincenzobaz @sashi-coursera