Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assignment of KR.2 instead of LT.1 #60

Open
Xhyn-Yus opened this issue Jul 1, 2024 · 2 comments
Open

Assignment of KR.2 instead of LT.1 #60

Xhyn-Yus opened this issue Jul 1, 2024 · 2 comments

Comments

@Xhyn-Yus
Copy link

Xhyn-Yus commented Jul 1, 2024

According to pangolin-designation v1.28, KR.2 has been redesignated as LT.1, however, pangolin-data v1.28 still assigns KR.2 instead of LT.1

@AngieHinrichs
Copy link
Member

Well, that is a bug. Thank you for reporting it! I will make a v1.28.1 data release. [heads up @kapsakcj]

@AngieHinrichs
Copy link
Member

Thanks again @Xhyn-Yus for reporting this. It is fixed in pangolin-data release v1.28.1.

[The problem was that I needed to modify three files in my daily tree update process to replace KR.2 with LT.1, but I only updated two of them and forgot about the third. As a result, LT.1 was added at the correct location, but the KR.2 annotation snuck back in on a child branch of LT.1, and the majority of LT.1 sequences are on that child branch. I will add some checks to make sure that lineages that don't belong in the tree have truly been removed.]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants