E2E test migration #226
Draft
E2E test migration #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Description Base test contract for forked tests in e2e tests ## Test Plan CI ## Related Issues
## Description This PR replaces llamarpc with merkle.io for the RPC as there are higher RPS. ## Test Plan 1. Ensure CI/CD remains green for fork tests. ## Related Issues N/A
## Description In order to make use of cache, and to convey to testers / developers what the assumptions of fork tests are, the fork block number is established as a constant within the `Helper.sol`. ## Test Plan 1. Verify that CI/CD passes. ## Related Issues N/A
## Description This PR sets the `FORK_URL` environment variable to a mainnet archive node with sufficient RPS / capacity to facilitate the fork tests. ## Test Plan 1. Verify CI/CD green. ## Related Issues N/A
## Description Migrate buyEth e2e test to foundry. Depends on #215 ## Test Plan CI ## Related Issues Closes #135 <!-- List related issues here --> <!-- Closes #issue (optional) --> --------- Co-authored-by: mfw78 <[email protected]>
## Description Migrate the smartOrder e2e test to foundry. Depends on #215. ## Test Plan CI ## Related Issues Issue doesn't exist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is to close out the milestone of migrating tests to foundry. As all E2E tests have been migrated into the
e2e-migrationbranch for staging purposes, this PR then merges (through use of rebase / fast-forward) these tests to themainbranch.Test Plan
Related Issues
#130