Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Min received amount does not include fee #2709

Closed
elena-zh opened this issue Jun 22, 2023 · 0 comments
Closed

Min received amount does not include fee #2709

elena-zh opened this issue Jun 22, 2023 · 0 comments
Labels
app:CowSwap CowSwap app Bug Something isn't working Medium Severity indicator. It causes some undesirable behavior, but the system is still functional RELEASE Included in the release that is being closed TWAP

Comments

@elena-zh
Copy link

Price with slippage and fees includes only slippage now, and does not include Fees, See the discussion https://cowservices.slack.com/archives/C053B0162VD/p1686747328866449

image.png

Anxo:

ALso, i think we shoul not use "slippage word"

And it would be great to remove 'Limit' from the price label.
@elena-zh elena-zh added app:CowSwap CowSwap app Bug Something isn't working Medium Severity indicator. It causes some undesirable behavior, but the system is still functional TWAP labels Jun 22, 2023
@shoom3301 shoom3301 added the RELEASE Included in the release that is being closed label Jun 30, 2023
@elena-zh elena-zh closed this as completed Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
app:CowSwap CowSwap app Bug Something isn't working Medium Severity indicator. It causes some undesirable behavior, but the system is still functional RELEASE Included in the release that is being closed TWAP
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shoom3301 @elena-zh