Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TWAP filled parts are missing in the History section #2717

Closed
elena-zh opened this issue Jun 22, 2023 · 2 comments
Closed

TWAP filled parts are missing in the History section #2717

elena-zh opened this issue Jun 22, 2023 · 2 comments
Labels
app:CowSwap CowSwap app Bug Something isn't working Medium Severity indicator. It causes some undesirable behavior, but the system is still functional RELEASE Included in the release that is being closed TWAP

Comments

@elena-zh
Copy link

  1. Place a TWAP order and wait till it is (or all its parts) are executed
  2. Refresh the Safe app (reload)
  3. Open Your orders table, history tab
  4. Check for the filled parts of a TWAP order

AR: they are not displayed. I can see only cancelled parts and cancelled and expired parent orders
missing1.png
ER: these parts are displayed.

@elena-zh elena-zh added app:CowSwap CowSwap app Bug Something isn't working Medium Severity indicator. It causes some undesirable behavior, but the system is still functional TWAP labels Jun 22, 2023
@shoom3301
Copy link
Collaborator

Currently, we derive part orders only using getTradeableOrderWithSignature. But it doesn't work for expired or canceled orders. So, to display part orders of expired twap orders, we need to calculate parts ids using #2640

@shoom3301 shoom3301 added the RELEASE Included in the release that is being closed label Jun 30, 2023
@elena-zh
Copy link
Author

elena-zh commented Jul 5, 2023

Fixed in #2764

@elena-zh elena-zh closed this as completed Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:CowSwap CowSwap app Bug Something isn't working Medium Severity indicator. It causes some undesirable behavior, but the system is still functional RELEASE Included in the release that is being closed TWAP
Projects
None yet
Development

No branches or pull requests

2 participants