feat(permit): refactor permit caching #3183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
anxolin
reviewed
Oct 4, 2023
anxolin
approved these changes
Oct 4, 2023
alfetopito
force-pushed
the
permit/3145_modals-limit
branch
from
1e5659c
to
500df69
Compare
alfetopito
force-pushed
the
permit/3146_refactor-permit-caching
branch
from
07d973e
to
e4405ef
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #3146
Built on top/waterfalls onto #3164
Refactor permit caching from localStorage to a jotai atom.
Split storage between static (used for quotes with a fixed PK) and user (signed by users before placing the orders).
Is the basis to implement #3146, coming next.
To Test