Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.48.0] Safe/SC wallet contains hook info #3207

Closed
alfetopito opened this issue Oct 12, 2023 · 0 comments
Closed

[1.48.0] Safe/SC wallet contains hook info #3207

alfetopito opened this issue Oct 12, 2023 · 0 comments
Assignees
@alfetopito
Labels
RELEASE Included in the release that is being closed

Comments

@alfetopito
Copy link
Collaborator

alfetopito commented Oct 12, 2023 •
edited
Loading

Description

A Safe order contains permit hook info: https://dev.explorer.cow.fi/goerli/orders/0x21b9c5bbf6b9f4ad8bfaccf630aeaad029ab92abbe5ddd35dfa7c97ab17add045895fcf0a96a4d19e17d2dd759926d1a02781ef86527ca40?tab=overview

How to Reproduce

  1. Using the release build https://swap-dev-git-release-1480-cowswap.vercel.app
  2. Load it as a Safe custom app OR use another SC wallet
  3. Pick a permittable token to sell
  4. Make sure there's no allowance for it
  5. Place the sell order
  6. Order contains permit hooks data

Expected behavior

  • SC wallets should NOT contain any permit hook data

Context

From release 1.48.0 #3203
@alfetopito alfetopito added the RELEASE Included in the release that is being closed label Oct 12, 2023
@alfetopito alfetopito mentioned this issue Oct 12, 2023
Merged
@alfetopito alfetopito self-assigned this Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alfetopito alfetopito

Labels
RELEASE Included in the release that is being closed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alfetopito