Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.48.0] Cannot swap/post order when there is not enough allowance #3215

Closed
shoom3301 opened this issue Oct 12, 2023 · 1 comment
Closed

[1.48.0] Cannot swap/post order when there is not enough allowance #3215

shoom3301 opened this issue Oct 12, 2023 · 1 comment
Labels
Bug Something isn't working RELEASE Included in the release that is being closed

Comments

@shoom3301
Copy link
Collaborator

Description

Cannot swap/post order when there is not enough allowance, but App doesn't know about it

image

How to Reproduce
Steps to reproduce the behavior:

  1. Open swap and set a trade with token with enough allowance
  2. Revoke allowance (https://revoke.cash/)
  3. Just after tx mined try to swap
  4. AR: empty modal (see pic above)

Expected behavior
Should display the corresponding error or propose to approve/sign permit

Additional context
We should check allowance ob blockchain just before data signing and propose approving/permit signing
@shoom3301 shoom3301 added the Bug Something isn't working label Oct 12, 2023
@alfetopito alfetopito changed the title Cannot swap/post order when there is not enough allowance [1.48.0] Cannot swap/post order when there is not enough allowance Oct 12, 2023
@alfetopito alfetopito added the RELEASE Included in the release that is being closed label Oct 12, 2023
@shoom3301
Copy link
Collaborator Author

Double: #3217

@shoom3301 shoom3301 closed this as not planned Won't fix, can't repro, duplicate, stale Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working RELEASE Included in the release that is being closed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alfetopito @shoom3301