Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Permit: USDC pending approval on LIMIT #3245

Closed
alfetopito opened this issue Oct 18, 2023 · 0 comments · Fixed by #3247
Closed

Permit: USDC pending approval on LIMIT #3245

alfetopito opened this issue Oct 18, 2023 · 0 comments · Fixed by #3247
Assignees
@alfetopito
Labels
Bug Something isn't working permit

Comments

@alfetopito
Copy link
Collaborator

Description

USDC pending approval is not recognized on limit orders.

How to Reproduce

  1. On mainnet, make sure USDC has no approval
  2. Create a LIMIT order selling USDC
  3. Sign the permit, etc
  4. Once the order is placed, after ~1m the permit checker will run and identify whether the permit is valid
  5. It's not recognizing it as so, and prompting the user to do a manual approval

Expected behavior

There should be no approval warning

Screenshots

image (2)

Additional context

From this thread
@alfetopito alfetopito self-assigned this Oct 18, 2023
@alfetopito alfetopito added Bug Something isn't working permit labels Oct 18, 2023
@alfetopito alfetopito mentioned this issue Oct 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alfetopito alfetopito

Labels
Bug Something isn't working permit
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(permit): usdc limit orders warning cowprotocol/cowswap
2 participants
@alfetopito @elena-zh