Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(permit): don't show gas-free flags when permit is not supported #3346

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

alfetopito
Copy link
Collaborator

Summary

Only show the flags for EOAs

To Test

  1. Load the app on mainnet without connecting a wallet
  2. Open the token selector dropdown
  • Gas-less flag should be displayed on some tokens
  1. Connect an EOA wallet
  • Gas-less flag should be displayed on some tokens
  1. Connect a SC wallet
  • There should be no gas-less flags at all

@alfetopito alfetopito self-assigned this Nov 7, 2023
Copy link

vercel bot commented Nov 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cosmos ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2023 11:34am
swap-dev ✅ Ready (Inspect) Visit Preview Nov 7, 2023 11:34am
widget-configurator ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2023 11:34am

Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Work great! Also, nice it doesn't show up for SC wallets in limit or swap either. Great catch

@shoom3301 shoom3301 merged commit 1a56029 into release/1.49.0 Nov 7, 2023
11 of 12 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2023
@alfetopito alfetopito deleted the gas-free-only-when-supported branch November 7, 2023 13:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants