Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tokens): use default value for user-added tokens migration #3347

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

shoom3301
Copy link
Collaborator

Summary

Context: https://cowservices.slack.com/archives/C0361CDG8GP/p1699355067687489

The old redux state of user-added tokens might be not full, so we need to add default values for all networks for it.

image

image

To Test

  1. locally checkout previous release (1.48.17)
  2. Open localhost and clean localStorage
  3. Reload the page
  4. Add a custom token only to one network (for example Mainnet)
  5. Close the tab
  6. Switch to 1.49 release branch
  7. Open localhost again
  • AR: App crashes with the error above
  • ER: App doesn't crash, you still have the token you added before

@shoom3301 shoom3301 requested a review from a team November 7, 2023 11:29
@shoom3301 shoom3301 self-assigned this Nov 7, 2023
Copy link

vercel bot commented Nov 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
cosmos ✅ Ready (Inspect) Visit Preview Nov 7, 2023 11:30am
swap-dev ✅ Ready (Inspect) Visit Preview Nov 7, 2023 11:30am
widget-configurator ✅ Ready (Inspect) Visit Preview Nov 7, 2023 11:30am

@shoom3301 shoom3301 merged commit c9e235c into release/1.49.0 Nov 7, 2023
11 of 12 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2023
@alfetopito alfetopito deleted the fix/tokens-migration branch November 8, 2023 13:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants