Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Permit modal blinks before a trade #4941

Open
elena-zh opened this issue Oct 3, 2024 · 0 comments
Open

Permit modal blinks before a trade #4941

elena-zh opened this issue Oct 3, 2024 · 0 comments
Labels
Bug Something isn't working Trivial Issues with trivial priority

Comments

@elena-zh
Copy link

elena-zh commented Oct 3, 2024

  1. Open Limit orders page
  2. Select a token pair with a permittable token in the Sell field, the token should not have allowance
  3. Sign the permit and do not proceed with the trade
  4. Go to Hooks tab
  5. Specify a trade with the same token pair
  6. Check the screen while signing a TX

AR: Sign permit modal blinks . See the video: https://www.loom.com/share/b4a81dc323af45a3b6ea2d335642eaeb

ER: the permit modal should not appear
@elena-zh elena-zh added Bug Something isn't working Low Severity indicator for defects. It won't cause any major break-down of the system Hooks store labels Oct 3, 2024
@elena-zh elena-zh added Trivial Issues with trivial priority and removed Low Severity indicator for defects. It won't cause any major break-down of the system labels Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working Trivial Issues with trivial priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shoom3301 @elena-zh