Signing onchain transactions in mobile MM/1Inch goes through opening the app in AppStore

[elena-zh]

Related to #502

Originally reported in #444 (comment)

Some more context: #444 (review)

I see a request to open App store when I send a request to Approve a token using MM

However, I proceeded and opened the AppStore, then opened MM from there, and was able to sign the approve transactions. Afterwards I was redirected back to the app store.
The same is for the warp/unwrap/convert transactions.
Here is the video: https://drive.google.com/file/d/1jR5AuVWL0O-PMRuIPdQod5uc7AGR-Hm4/view?usp=sharing

The same is for the 1Inch wallet. However, the CowSwap app page is changed to that one https://wallet.1inch.io/wc/, and transaction does not appear in the activity modal when go back to the Cowswap app.

[fairlighteth]

Hehe, nice music selection 🎶 !

So following the screen recording, it looks like:

• It brings you to the AppStore even though you already had MetaMask installed?
• When you click on OPEN in the AppStore, it opens your already installed MetaMask and you see the transaction signing request. When you sign, nothing seems to be signed/transmitted to the UI?

[elena-zh]

@fairlighteth , thanks=)

1. Yes, it opens AppStore even the app is already installed
2. When I sigh:

• for MM: the Tx is signed, but I'm navigated back to the AppStore, and need 'manually' go back to the browser to open the Cowswap app
• for 1Inch: the TX is signed, but nothing is transmitted to the UI

[elena-zh]

I have retested the issue in #502 PR and I faced this intermediate message only once after connection a wallet in MM when testing in iOS. Then transactions started to run nicely with MM.
Video: https://cowservices.slack.com/files/UHCSH5J5C/F03E7303PR8/mm.mp4

As for the 1Inch wallet, I always face an intermediate step when try to sign onchain transactions in iOS. However, transactions started to be visible in the Cowswap.

in Android all types of transactions work fine for both 1Inch and MM wallets

[elena-zh]

Still reproducible in iOS in Staging.
I do not know why, but sometimes I do not see an intermediate step, sometimes - always see it (MM connection)

[anxolin]

Apparently is a well know bug https://community.metamask.io/t/deeplink-opens-appstore-when-app-installed/18199/20 a bit sad

[anxolin]

Also a related issue, MetaMask/metamask-mobile#3965

They show there a workaround (MetaMask/metamask-mobile#3965 (comment)), but we are not the ones generating the deep link (is Wallet connect), and second, there's someone that says that it doesn't work

[anxolin]

Also related issue, here they mentioned that is solved in MM 5.0.1, but for me it still reproduces.
MetaMask/metamask-mobile#3914

Very annoying also that Uniswap uses web-react and they don't have this issue afait.

[anxolin]

Theres a few solutions suggested here MetaMask/metamask-mobile#3965 @nenadV91 can you take a look?

[elena-zh]

Fixed in MetaMask/metamask-mobile#3914 (comment)