Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

public $foo { set(Bar $foo); } throws syntax error. #31

Closed
cpriest opened this issue Jan 5, 2013 · 3 comments
Closed

public $foo { set(Bar $foo); } throws syntax error. #31

cpriest opened this issue Jan 5, 2013 · 3 comments
Assignees
Labels

Comments

@cpriest
Copy link
Owner

cpriest commented Jan 5, 2013

Just noticed that typehinted set without body currently doesn't work at all. public $foo { set(Bar $foo); } throws a parser error.

@nikic
Copy link
Collaborator

nikic commented Jan 9, 2013

I fixed the "syntax error" part of this, but it still won't work because the generated code relies on the parameter name being $value.

@cpriest
Copy link
Owner Author

cpriest commented Jan 9, 2013

That shouldn't be too hard to fix, the arguments for the function declaration should be parsed by that point. If that code is committed I can look into that as soon as i am out of this current rabbit hole.

-Clint

On Jan 8, 2013, at 6:02 PM, nikic [email protected] wrote:

I fixed the "syntax error" part of this, but it still won't work because the generated code relies on the parameter name being $value.


Reply to this email directly or view it on GitHub.

@nikic
Copy link
Collaborator

nikic commented Jan 9, 2013

@cpriest Yeah, that was a brainfart on my behalf. Somehow didn't come to my mind that this is trivially fixable ^^

Fixed by 679890c, closing.

@nikic nikic closed this as completed Jan 9, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants