Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scala.js source maps point to wrong root #25

Closed
chuwy opened this issue Feb 28, 2017 · 6 comments
Closed

Scala.js source maps point to wrong root #25

chuwy opened this issue Feb 28, 2017 · 6 comments

Comments

@chuwy
Copy link

chuwy commented Feb 28, 2017

JS Source maps for threetenbp and scalajs-locales point to wrong local root /Users/cquiroz/Projects. I think this should point to raw.githubusercontent.com similar to cats: typelevel/cats#916

@cquiroz
Copy link
Owner

cquiroz commented Feb 28, 2017

Hi, that's good to know. Thanks for the info

@cquiroz
Copy link
Owner

cquiroz commented Mar 1, 2017

I'm replicating the fix but I'm not sure how to test it, can you comment?

@cquiroz
Copy link
Owner

cquiroz commented Mar 1, 2017

The last PR wasn't correct, reopening

@cquiroz cquiroz reopened this Mar 1, 2017
@chuwy
Copy link
Author

chuwy commented Mar 6, 2017

Sorry @cquiroz, didn't see your comments.

What exactly went wrong with that PR?
As for testing, it should emit source maps with line similar to https://raw.githubusercontent.com/scala-js/scala-js/v0.6.14/tools/scalajsenv.js as opposed to file:///Users/cquiroz/Projects/threetenbp/js/target/scala-2.12/src_managed/main/org/threeten/bp/LocalDate.scala. Here's example project using this library with Scala.js.

@cquiroz
Copy link
Owner

cquiroz commented Mar 6, 2017

The issue is that the default setting works for code in the usual places, but scala-java-time has generated code. I think it shouldn't be that hard to get it right

I wonder if you can pass multiple mappings

@cquiroz
Copy link
Owner

cquiroz commented Mar 9, 2017

Fixed by PR #32

@cquiroz cquiroz closed this as completed Mar 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants