Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release checks public registry even with publish set to a private one #736

Open
bobrik opened this issue Dec 28, 2023 · 1 comment
Open
Labels
bug Not as expected

Comments

@bobrik
Copy link

bobrik commented Dec 28, 2023

See #732 and #735.

If a crate has the following set in [package] in Cargo.toml:

publish = ["myregistry"]

Here's the documentation:

If publish array contains a single registry, cargo publish command will use it when --registry flag is not specified.

It would be good if cargo-release followed the same heuristic. Currently one needs to pass --registry manually, otherwise the public registry is checked, which might not be accessible and it leaks crate names (#732).

@epage
Copy link
Collaborator

epage commented Dec 29, 2023

The key quote to keep in mind from that documentation:

If publish array contains a single registry, cargo publish command will use it when --registry flag is not specified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Not as expected
Projects
None yet
Development

No branches or pull requests

2 participants