Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False Positive UIU should be YOU #1002

Open
xavier2k6 opened this issue Apr 17, 2024 · 3 comments
Open

False Positive UIU should be YOU #1002

xavier2k6 opened this issue Apr 17, 2024 · 3 comments
Labels
bug Not as expected

Comments

@xavier2k6
Copy link

xavier2k6 commented Apr 17, 2024

typos 1.20.9

UIU of WebUIUPnp is being falsely detected as YOU

WebUI is an abbreviation/acronym for Web User Interface
UPnP is an abbreviation/acronym for Universal Plug and Play

Screenshot 2024-04-17 183951

@epage epage added the bug Not as expected label Apr 17, 2024
@epage
Copy link
Collaborator

epage commented Apr 17, 2024

Currently, our word splitting strictly follows CamelCase and so it splits checkWebUIUPnP as check Web UIU Pn P. You can see this by running typos --words

This is somewhat like #466 where some "identifiers" don't follow standard conventions. So far, we've not come up with a better plan for handling these cases.

These cases can be worked around by

  • Marking that identifier valid
  • Marking identifiers with WebUI or UPnP as valid via regex

@xavier2k6
Copy link
Author

@epage Thanks for the tip!

Modified .typos.toml & now passed.

[default.extend-words]
BA = "BA"
helo = "helo"
UIU = "UIU"
Pn = "Pn"

@szepeviktor
Copy link
Contributor

szepeviktor commented Apr 21, 2024

It is rather

[default.extend-identifiers]
checkWebUIUPnP = "checkWebUIUPnP"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Not as expected
Projects
None yet
Development

No branches or pull requests

3 participants