Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "cancel" as per current locale #948

Closed
szepeviktor opened this issue Mar 22, 2024 · 3 comments
Closed

Fix "cancel" as per current locale #948

szepeviktor opened this issue Mar 22, 2024 · 3 comments

Comments

@szepeviktor
Copy link
Contributor

Currently with default locale "canceled" is a marked as a typo.

The forms of cancel in American English are typically canceled and canceling; in British English they are cancelled and cancelling.

https://www.merriam-webster.com/dictionary/cancel

en_us -> canceled, canceling
en_gb -> cancelled, cancelling

Thank you.

@szepeviktor
Copy link
Contributor Author

But

There are examples of cancelled in American use, and of canceled in British, so you needn’t feel bad about yourself if you mistakenly use the variant that is less common where you live

https://www.merriam-webster.com/grammar/canceled-or-cancelled

@epage
Copy link
Collaborator

epage commented Jun 23, 2024

Sorry for the delay.

You mentioned "default locale". Without setting a locale, I do not see it corrected. Alternatively, 10 days before this post, you posted
#943 (comment)

Could you clarify under what conditions you are seeing what behavior?

@szepeviktor
Copy link
Contributor Author

szepeviktor commented Jun 23, 2024

That might be a mistake. Even v1.19.0 allows both versions.

@szepeviktor szepeviktor closed this as not planned Won't fix, can't repro, duplicate, stale Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants