From d227e59001ce57abad588ec486d40388cba2bc4c Mon Sep 17 00:00:00 2001 From: pranalidhanavade Date: Sun, 24 Dec 2023 20:34:46 +0530 Subject: [PATCH 1/5] refactor:email exist api Signed-off-by: pranalidhanavade --- apps/api-gateway/src/user/user.controller.ts | 2 +- apps/api-gateway/src/user/user.service.ts | 6 +++--- apps/user/interfaces/user.interface.ts | 2 +- apps/user/src/user.controller.ts | 6 +++--- apps/user/src/user.service.ts | 14 +++++++------- 5 files changed, 15 insertions(+), 15 deletions(-) diff --git a/apps/api-gateway/src/user/user.controller.ts b/apps/api-gateway/src/user/user.controller.ts index a4d295757..a4e05dc7a 100644 --- a/apps/api-gateway/src/user/user.controller.ts +++ b/apps/api-gateway/src/user/user.controller.ts @@ -254,7 +254,7 @@ export class UserController { const finalResponse: IResponseType = { statusCode: HttpStatus.OK, message: ResponseMessages.user.success.checkEmail, - data: userDetails.response + data: userDetails }; return res.status(HttpStatus.OK).json(finalResponse); diff --git a/apps/api-gateway/src/user/user.service.ts b/apps/api-gateway/src/user/user.service.ts index a9ff4d91a..221c7d8d4 100644 --- a/apps/api-gateway/src/user/user.service.ts +++ b/apps/api-gateway/src/user/user.service.ts @@ -9,7 +9,7 @@ import { UpdateUserProfileDto } from './dto/update-user-profile.dto'; import { AddPasskeyDetails } from './dto/add-user.dto'; import { UpdatePlatformSettingsDto } from './dto/update-platform-settings.dto'; import { CreateUserCertificateDto } from './dto/share-certificate.dto'; -import { IUsersProfile } from 'apps/user/interfaces/user.interface'; +import { IUsersProfile, ICheckUserDetails } from 'apps/user/interfaces/user.interface'; import { IUsersActivity } from 'libs/user-activity/interface'; @Injectable() @@ -74,9 +74,9 @@ export class UserService extends BaseService { return this.sendNatsMessage(this.serviceProxy, 'fetch-users', payload); } - async checkUserExist(userEmail: string): Promise<{ response: string }> { + async checkUserExist(userEmail: string): Promise { const payload = { userEmail }; - return this.sendNats(this.serviceProxy, 'check-user-exist', payload); + return this.sendNatsMessage(this.serviceProxy, 'check-user-exist', payload); } async getUserActivities(userId: string, limit: number): Promise { diff --git a/apps/user/interfaces/user.interface.ts b/apps/user/interfaces/user.interface.ts index 28ef25f61..a3f6fecb7 100644 --- a/apps/user/interfaces/user.interface.ts +++ b/apps/user/interfaces/user.interface.ts @@ -112,7 +112,7 @@ interface IUserOrgRole { label: string; } - export interface CheckUserDetails { + export interface ICheckUserDetails { isEmailVerified?: boolean; isFidoVerified?: boolean; isSupabase?: boolean; diff --git a/apps/user/src/user.controller.ts b/apps/user/src/user.controller.ts index 4f8770b97..9719e9a0b 100644 --- a/apps/user/src/user.controller.ts +++ b/apps/user/src/user.controller.ts @@ -1,4 +1,4 @@ -import { AddPasskeyDetails, CheckUserDetails, PlatformSettings, ShareUserCertificate, UserInvitations, UpdateUserProfile, UserCredentials, UserEmailVerificationDto, IUserInformation, IUsersProfile } from '../interfaces/user.interface'; +import { AddPasskeyDetails, ICheckUserDetails, PlatformSettings, ShareUserCertificate, UpdateUserProfile, UserCredentials, UserEmailVerificationDto, IUserInformation, IUsersProfile, UserInvitations } from '../interfaces/user.interface'; import {IOrgUsers, Payload} from '../interfaces/user.interface'; import { AcceptRejectInvitationDto } from '../dtos/accept-reject-invitation.dto'; @@ -72,7 +72,7 @@ export class UserController { @MessagePattern({ cmd: 'get-org-invitations' }) async invitations(payload: { id; status; pageNumber; pageSize; search; }): Promise { - return this.userService.invitations(payload); + return this.userService.invitations(payload); } /** @@ -122,7 +122,7 @@ export class UserController { } @MessagePattern({ cmd: 'check-user-exist' }) - async checkUserExist(payload: { userEmail: string }): Promise { + async checkUserExist(payload: { userEmail: string }): Promise { return this.userService.checkUserExist(payload.userEmail); } @MessagePattern({ cmd: 'add-user' }) diff --git a/apps/user/src/user.service.ts b/apps/user/src/user.service.ts index 552f9a4ca..1f2f1b367 100644 --- a/apps/user/src/user.service.ts +++ b/apps/user/src/user.service.ts @@ -29,17 +29,17 @@ import { user } from '@prisma/client'; import { AddPasskeyDetails, Attribute, - CheckUserDetails, + ICheckUserDetails, OrgInvitations, PlatformSettings, ShareUserCertificate, - UserInvitations, IOrgUsers, UpdateUserProfile, UserCredentials, UserEmailVerificationDto, IUserInformation, - IUsersProfile + IUsersProfile, + UserInvitations } from '../interfaces/user.interface'; import { AcceptRejectInvitationDto } from '../dtos/accept-reject-invitation.dto'; import { UserActivityService } from '@credebl/user-activity'; @@ -458,7 +458,7 @@ export class UserService { if (!userData) { throw new NotFoundException(ResponseMessages.user.error.notFound); } - + const invitationsData = await this.getOrgInvitations( userData.email, payload.status, @@ -466,11 +466,11 @@ export class UserService { payload.pageSize, payload.search ); - + const invitations: OrgInvitations[] = await this.updateOrgInvitations(invitationsData['invitations']); invitationsData['invitations'] = invitations; // console.log("{-----------------}",invitationsData); - + return invitationsData; } catch (error) { this.logger.error(`Error in get invitations: ${JSON.stringify(error)}`); @@ -728,7 +728,7 @@ export class UserService { } } - async checkUserExist(email: string): Promise { + async checkUserExist(email: string): Promise { try { const userDetails = await this.userRepository.checkUniqueUserExist(email); if (userDetails && !userDetails.isEmailVerified) { From 60a8dbb3161f0f2c606e90b5fada17aa60ad87c0 Mon Sep 17 00:00:00 2001 From: pranalidhanavade Date: Tue, 26 Dec 2023 19:30:38 +0530 Subject: [PATCH 2/5] refactor:verify-user-and-send-verification-mail-api Signed-off-by: pranalidhanavade --- .../api-gateway/src/authz/authz.controller.ts | 8 ++--- apps/api-gateway/src/authz/authz.service.ts | 11 +++---- .../src/user/dto/email-verify.dto.ts | 3 +- apps/user/interfaces/user.interface.ts | 10 ++++-- apps/user/repositories/user.repository.ts | 32 +++++++++---------- apps/user/src/user.controller.ts | 8 ++--- apps/user/src/user.service.ts | 31 +++++++++--------- libs/common/src/response-messages/index.ts | 3 +- 8 files changed, 56 insertions(+), 50 deletions(-) diff --git a/apps/api-gateway/src/authz/authz.controller.ts b/apps/api-gateway/src/authz/authz.controller.ts index 3e35edf4f..cafaedfe7 100644 --- a/apps/api-gateway/src/authz/authz.controller.ts +++ b/apps/api-gateway/src/authz/authz.controller.ts @@ -41,7 +41,7 @@ export class AuthzController { * @returns User email verified */ @Get('/verify') - @ApiResponse({ status: 200, description: 'Success', type: ApiResponseDto }) + @ApiResponse({ status: HttpStatus.OK, description: 'Success', type: ApiResponseDto }) @ApiOperation({ summary: 'Verify user’s email', description: 'Verify user’s email' }) async verifyEmail(@Query() query: EmailVerificationDto, @Res() res: Response): Promise { await this.authzService.verifyEmail(query); @@ -61,10 +61,10 @@ export class AuthzController { * @returns Email sent success */ @Post('/verification-mail') - @ApiResponse({ status: 201, description: 'Success', type: ApiResponseDto }) + @ApiResponse({ status: HttpStatus.CREATED, description: 'Created', type: ApiResponseDto }) @ApiOperation({ summary: 'Send verification email', description: 'Send verification email to new user' }) - async create(@Body() userEmailVerificationDto: UserEmailVerificationDto, @Res() res: Response): Promise { - await this.authzService.sendVerificationMail(userEmailVerificationDto); + async create(@Body() userEmailVerification: UserEmailVerificationDto, @Res() res: Response): Promise { + await this.authzService.sendVerificationMail(userEmailVerification); const finalResponse: IResponseType = { statusCode: HttpStatus.CREATED, message: ResponseMessages.user.success.sendVerificationCode diff --git a/apps/api-gateway/src/authz/authz.service.ts b/apps/api-gateway/src/authz/authz.service.ts index 317712669..5a5f17203 100644 --- a/apps/api-gateway/src/authz/authz.service.ts +++ b/apps/api-gateway/src/authz/authz.service.ts @@ -28,15 +28,14 @@ export class AuthzService extends BaseService { return this.sendNats(this.authServiceProxy, 'get-user-by-keycloakUserId', keycloakUserId); } - async sendVerificationMail(userEmailVerificationDto: UserEmailVerificationDto): Promise { - const payload = { userEmailVerificationDto }; - return this.sendNats(this.authServiceProxy, 'send-verification-mail', payload); + async sendVerificationMail(userEmailVerification: UserEmailVerificationDto): Promise { + const payload = { userEmailVerification }; + return this.sendNatsMessage(this.authServiceProxy, 'send-verification-mail', payload); } - async verifyEmail(param: EmailVerificationDto): Promise { + async verifyEmail(param: EmailVerificationDto): Promise { const payload = { param }; - return this.sendNats(this.authServiceProxy, 'user-email-verification', payload); - + return this.sendNatsMessage(this.authServiceProxy, 'user-email-verification', payload); } async login(email: string, password?: string, isPasskey = false): Promise<{ response: object }> { diff --git a/apps/api-gateway/src/user/dto/email-verify.dto.ts b/apps/api-gateway/src/user/dto/email-verify.dto.ts index 23c4acd5a..c54db401d 100644 --- a/apps/api-gateway/src/user/dto/email-verify.dto.ts +++ b/apps/api-gateway/src/user/dto/email-verify.dto.ts @@ -1,4 +1,4 @@ -import { IsEmail, IsNotEmpty, MaxLength } from 'class-validator'; +import { IsEmail, IsNotEmpty, IsString, MaxLength } from 'class-validator'; import { toLowerCase, trim } from '@credebl/common/cast.helper'; import { ApiProperty } from '@nestjs/swagger'; @@ -17,5 +17,6 @@ export class EmailVerificationDto { @ApiProperty() @Transform(({ value }) => trim(value)) @IsNotEmpty({ message: 'Verification code is required.' }) + @IsString({ message: 'Verification code should be string' }) verificationCode: string; } diff --git a/apps/user/interfaces/user.interface.ts b/apps/user/interfaces/user.interface.ts index a3f6fecb7..c495c5fc1 100644 --- a/apps/user/interfaces/user.interface.ts +++ b/apps/user/interfaces/user.interface.ts @@ -66,8 +66,8 @@ interface IUserOrgRole { email?: string; orgRoles: string[]; } - - export interface UserEmailVerificationDto { + + export interface ISendVerificationEmail { email: string; username?: string; } @@ -175,3 +175,9 @@ interface IUserOrgRole { pageSize: number; search: string; } + + export class IVerifyUserEmail { + email: string; + verificationCode: string; +} + diff --git a/apps/user/repositories/user.repository.ts b/apps/user/repositories/user.repository.ts index 32c1d4b2e..59c406882 100644 --- a/apps/user/repositories/user.repository.ts +++ b/apps/user/repositories/user.repository.ts @@ -7,11 +7,11 @@ import { ShareUserCertificate, UpdateUserProfile, UserCredentials, - UserEmailVerificationDto, - IUsersProfile, - IUserInformation + ISendVerificationEmail, + IUsersProfile, + IUserInformation, + IVerifyUserEmail } from '../interfaces/user.interface'; - import { InternalServerErrorException } from '@nestjs/common'; import { PrismaService } from '@credebl/prisma-service'; // eslint-disable-next-line camelcase @@ -27,21 +27,21 @@ interface UserQueryOptions { @Injectable() export class UserRepository { constructor( - private readonly prisma: PrismaService, + private readonly prisma: PrismaService, private readonly logger: Logger ) {} /** * - * @param userEmailVerificationDto + * @param userEmailVerification * @returns user email */ - async createUser(userEmailVerificationDto: UserEmailVerificationDto, verifyCode: string): Promise { + async createUser(userEmailVerification:ISendVerificationEmail, verifyCode: string): Promise { try { const saveResponse = await this.prisma.user.create({ data: { - username: userEmailVerificationDto.username, - email: userEmailVerificationDto.email, + username: userEmailVerification.username, + email: userEmailVerification.email, verificationCode: verifyCode.toString(), publicProfile: true } @@ -247,11 +247,11 @@ export class UserRepository { website: true, publicProfile: true } + } } - } } } - }); + }); } async findUserForPublicProfile(queryOptions: UserQueryOptions): Promise { @@ -301,8 +301,8 @@ export class UserRepository { website: true, publicProfile: true } + } } - } } } }); @@ -375,15 +375,15 @@ export class UserRepository { }, select: { id: true, -username: true, + username: true, email: true, firstName: true, lastName: true, isEmailVerified: true, userOrgRoles: { - where: { + where: { ...filterOptions -// Additional filtering conditions if needed + // Additional filtering conditions if needed }, select: { id: true, @@ -526,7 +526,7 @@ username: true, } } - async verifyUser(email: string): Promise { + async verifyUser(email: string): Promise { try { const updateUserDetails = await this.prisma.user.update({ where: { diff --git a/apps/user/src/user.controller.ts b/apps/user/src/user.controller.ts index 9719e9a0b..7e9224ac9 100644 --- a/apps/user/src/user.controller.ts +++ b/apps/user/src/user.controller.ts @@ -1,4 +1,4 @@ -import { AddPasskeyDetails, ICheckUserDetails, PlatformSettings, ShareUserCertificate, UpdateUserProfile, UserCredentials, UserEmailVerificationDto, IUserInformation, IUsersProfile, UserInvitations } from '../interfaces/user.interface'; +import { AddPasskeyDetails, ICheckUserDetails, PlatformSettings, ShareUserCertificate, UpdateUserProfile, UserCredentials, IUserInformation, IUsersProfile, UserInvitations, ISendVerificationEmail, IVerifyUserEmail} from '../interfaces/user.interface'; import {IOrgUsers, Payload} from '../interfaces/user.interface'; import { AcceptRejectInvitationDto } from '../dtos/accept-reject-invitation.dto'; @@ -20,8 +20,8 @@ export class UserController { * @returns Get registered user response */ @MessagePattern({ cmd: 'send-verification-mail' }) - async sendVerificationMail(payload: { userEmailVerificationDto: UserEmailVerificationDto }): Promise { - return this.userService.sendVerificationMail(payload.userEmailVerificationDto); + async sendVerificationMail(payload: { userEmailVerification: ISendVerificationEmail }): Promise { + return this.userService.sendVerificationMail(payload.userEmailVerification); } /** @@ -30,7 +30,7 @@ export class UserController { * @returns Get user's email verified */ @MessagePattern({ cmd: 'user-email-verification' }) - async verifyEmail(payload: { param: VerifyEmailTokenDto }): Promise { + async verifyEmail(payload: { param: VerifyEmailTokenDto }): Promise { return this.userService.verifyEmail(payload.param); } diff --git a/apps/user/src/user.service.ts b/apps/user/src/user.service.ts index 1f2f1b367..530c18cbb 100644 --- a/apps/user/src/user.service.ts +++ b/apps/user/src/user.service.ts @@ -35,11 +35,12 @@ import { ShareUserCertificate, IOrgUsers, UpdateUserProfile, - UserCredentials, - UserEmailVerificationDto, + UserCredentials, + ISendVerificationEmail, IUserInformation, IUsersProfile, - UserInvitations + UserInvitations, + IVerifyUserEmail } from '../interfaces/user.interface'; import { AcceptRejectInvitationDto } from '../dtos/accept-reject-invitation.dto'; import { UserActivityService } from '@credebl/user-activity'; @@ -76,12 +77,12 @@ export class UserService { /** * - * @param userEmailVerificationDto + * @param userEmailVerification * @returns */ - async sendVerificationMail(userEmailVerificationDto: UserEmailVerificationDto): Promise { + async sendVerificationMail(userEmailVerification: ISendVerificationEmail): Promise { try { - const { email } = userEmailVerificationDto; + const { email } = userEmailVerification; if ('PROD' === process.env.PLATFORM_PROFILE_MODE) { // eslint-disable-next-line prefer-destructuring @@ -91,7 +92,7 @@ export class UserService { throw new BadRequestException(ResponseMessages.user.error.InvalidEmailDomain); } } - const userDetails = await this.userRepository.checkUserExist(userEmailVerificationDto.email); + const userDetails = await this.userRepository.checkUserExist(userEmailVerification.email); if (userDetails && userDetails.isEmailVerified) { throw new ConflictException(ResponseMessages.user.error.exists); @@ -102,12 +103,12 @@ export class UserService { } const verifyCode = uuidv4(); - const uniqueUsername = await this.createUsername(userEmailVerificationDto.email, verifyCode); - userEmailVerificationDto.username = uniqueUsername; - const resUser = await this.userRepository.createUser(userEmailVerificationDto, verifyCode); + const uniqueUsername = await this.createUsername(userEmailVerification.email, verifyCode); + userEmailVerification.username = uniqueUsername; + const resUser = await this.userRepository.createUser(userEmailVerification, verifyCode); try { - await this.sendEmailForVerification(userEmailVerificationDto.email, resUser.verificationCode); + await this.sendEmailForVerification(userEmailVerification.email, resUser.verificationCode); } catch (error) { throw new InternalServerErrorException(ResponseMessages.user.error.emailSend); } @@ -178,7 +179,7 @@ export class UserService { * @returns Email verification succcess */ - async verifyEmail(param: VerifyEmailTokenDto): Promise { + async verifyEmail(param: VerifyEmailTokenDto): Promise { try { const invalidMessage = ResponseMessages.user.error.invalidEmailUrl; @@ -197,10 +198,8 @@ export class UserService { } if (param.verificationCode === userDetails.verificationCode) { - await this.userRepository.verifyUser(param.email); - return { - message: 'User Verified sucessfully' - }; + const verifiedEmail = await this.userRepository.verifyUser(param.email); + return verifiedEmail; } } catch (error) { this.logger.error(`error in verifyEmail: ${JSON.stringify(error)}`); diff --git a/libs/common/src/response-messages/index.ts b/libs/common/src/response-messages/index.ts index db8744af6..afa31420c 100644 --- a/libs/common/src/response-messages/index.ts +++ b/libs/common/src/response-messages/index.ts @@ -13,11 +13,12 @@ export const ResponseMessages = { fetchUsers: 'Users fetched successfully', newUser: 'User not found', checkEmail: 'User email checked successfully.', - sendVerificationCode: 'Verification code has been sent sucessfully to the mail. Please verify', + sendVerificationCode: 'Verification link has been successfully sent on the email. Please verify', userActivity: 'User activities fetched successfully', userCredentials: 'User credentials fetched successfully', platformEcosystemettings: 'Platform and ecosystem settings updated', fetchPlatformSettings: 'Platform settings fetched' + }, error: { exists: 'User already exists', From ef181a4c4978f16a33246e37564d463e4e6f39dc Mon Sep 17 00:00:00 2001 From: pranalidhanavade Date: Tue, 26 Dec 2023 20:40:38 +0530 Subject: [PATCH 3/5] refactor:verify-user-and-send-verification-mail-api Signed-off-by: pranalidhanavade --- apps/api-gateway/src/authz/authz.controller.ts | 11 ++++------- apps/api-gateway/src/user/user.controller.ts | 3 +-- apps/user/interfaces/user.interface.ts | 2 +- apps/user/src/user.controller.ts | 18 +++++++++++------- 4 files changed, 17 insertions(+), 17 deletions(-) diff --git a/apps/api-gateway/src/authz/authz.controller.ts b/apps/api-gateway/src/authz/authz.controller.ts index cafaedfe7..7e8ff1f60 100644 --- a/apps/api-gateway/src/authz/authz.controller.ts +++ b/apps/api-gateway/src/authz/authz.controller.ts @@ -35,10 +35,9 @@ export class AuthzController { private readonly commonService: CommonService) { } /** - * - * @param query - * @param res - * @returns User email verified + * @param email + * @param verificationcode + * @returns User's email verification status */ @Get('/verify') @ApiResponse({ status: HttpStatus.OK, description: 'Success', type: ApiResponseDto }) @@ -55,10 +54,8 @@ export class AuthzController { } /** - * * @param email - * @param res - * @returns Email sent success + * @returns User's verification email sent status */ @Post('/verification-mail') @ApiResponse({ status: HttpStatus.CREATED, description: 'Created', type: ApiResponseDto }) diff --git a/apps/api-gateway/src/user/user.controller.ts b/apps/api-gateway/src/user/user.controller.ts index a4e05dc7a..02594d994 100644 --- a/apps/api-gateway/src/user/user.controller.ts +++ b/apps/api-gateway/src/user/user.controller.ts @@ -243,8 +243,7 @@ export class UserController { /** * * @param email - * @param res - * @returns User email check + * @returns User's email exist status */ @Get('/:email') @ApiOperation({ summary: 'Check user exist', description: 'check user existence' }) diff --git a/apps/user/interfaces/user.interface.ts b/apps/user/interfaces/user.interface.ts index c495c5fc1..678ed95c5 100644 --- a/apps/user/interfaces/user.interface.ts +++ b/apps/user/interfaces/user.interface.ts @@ -113,10 +113,10 @@ interface IUserOrgRole { } export interface ICheckUserDetails { + isExist: boolean; isEmailVerified?: boolean; isFidoVerified?: boolean; isSupabase?: boolean; - isExist?: boolean; } export interface UserCredentials { diff --git a/apps/user/src/user.controller.ts b/apps/user/src/user.controller.ts index 7e9224ac9..e20d5fd62 100644 --- a/apps/user/src/user.controller.ts +++ b/apps/user/src/user.controller.ts @@ -16,8 +16,8 @@ export class UserController { /** * Description: Registers new user - * @param payload Registration Details - * @returns Get registered user response + * @param email + * @returns User's verification email sent status */ @MessagePattern({ cmd: 'send-verification-mail' }) async sendVerificationMail(payload: { userEmailVerification: ISendVerificationEmail }): Promise { @@ -26,8 +26,9 @@ export class UserController { /** * Description: Verify user's email - * @param param - * @returns Get user's email verified + * @param email + * @param verificationcode + * @returns User's email verification status */ @MessagePattern({ cmd: 'user-email-verification' }) async verifyEmail(payload: { param: VerifyEmailTokenDto }): Promise { @@ -111,7 +112,6 @@ export class UserController { } /** - * * @param payload * @returns organization users list */ @@ -120,9 +120,13 @@ export class UserController { const users = this.userService.get(payload.pageNumber, payload.pageSize, payload.search); return users; } - + + /** + * @param email + * @returns User's email exist status + * */ @MessagePattern({ cmd: 'check-user-exist' }) - async checkUserExist(payload: { userEmail: string }): Promise { + async checkUserExist(payload: { userEmail: string }): Promise { return this.userService.checkUserExist(payload.userEmail); } @MessagePattern({ cmd: 'add-user' }) From 75965aa763f7874e6ae1d0210084169ee535fd76 Mon Sep 17 00:00:00 2001 From: pranalidhanavade Date: Tue, 26 Dec 2023 20:46:01 +0530 Subject: [PATCH 4/5] refactor:verify-user-and-send-verification-mail-api Signed-off-by: pranalidhanavade --- apps/user/src/user.service.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/apps/user/src/user.service.ts b/apps/user/src/user.service.ts index 530c18cbb..3c42129f8 100644 --- a/apps/user/src/user.service.ts +++ b/apps/user/src/user.service.ts @@ -468,7 +468,6 @@ export class UserService { const invitations: OrgInvitations[] = await this.updateOrgInvitations(invitationsData['invitations']); invitationsData['invitations'] = invitations; - // console.log("{-----------------}",invitationsData); return invitationsData; } catch (error) { From f96de9eeb6d60d7182d5273ac1b222e6fd36f7f8 Mon Sep 17 00:00:00 2001 From: pranalidhanavade Date: Wed, 27 Dec 2023 11:15:58 +0530 Subject: [PATCH 5/5] resolved:comments on code Signed-off-by: pranalidhanavade --- apps/api-gateway/src/user/user.controller.ts | 2 +- apps/user/repositories/user.repository.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/apps/api-gateway/src/user/user.controller.ts b/apps/api-gateway/src/user/user.controller.ts index 02594d994..6d7a69dd5 100644 --- a/apps/api-gateway/src/user/user.controller.ts +++ b/apps/api-gateway/src/user/user.controller.ts @@ -246,7 +246,7 @@ export class UserController { * @returns User's email exist status */ @Get('/:email') - @ApiOperation({ summary: 'Check user exist', description: 'check user existence' }) + @ApiOperation({ summary: 'Check if user exist', description: 'check user existence' }) async checkUserExist(@Param() emailParam: EmailValidator, @Res() res: Response): Promise { const userDetails = await this.userService.checkUserExist(emailParam.email); diff --git a/apps/user/repositories/user.repository.ts b/apps/user/repositories/user.repository.ts index 59c406882..6dbb300cd 100644 --- a/apps/user/repositories/user.repository.ts +++ b/apps/user/repositories/user.repository.ts @@ -34,7 +34,7 @@ export class UserRepository { /** * * @param userEmailVerification - * @returns user email + * @returns user's email */ async createUser(userEmailVerification:ISendVerificationEmail, verifyCode: string): Promise { try {