From db059ebe15295b8e47270eec7d2eaf8545630090 Mon Sep 17 00:00:00 2001
From: bhavanakarwade <bhavana.karwade@ayanworks.com>
Date: Wed, 31 Jan 2024 20:18:47 +0530
Subject: [PATCH] fix: refactor response of send cred def on ledger

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
---
 .../credential-definition.controller.ts                   | 8 ++++----
 .../credential-definition.service.ts                      | 4 ++--
 .../credential-definition.service.ts                      | 4 ++++
 3 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/apps/api-gateway/src/credential-definition/credential-definition.controller.ts b/apps/api-gateway/src/credential-definition/credential-definition.controller.ts
index 87656e696..4414f3bd4 100644
--- a/apps/api-gateway/src/credential-definition/credential-definition.controller.ts
+++ b/apps/api-gateway/src/credential-definition/credential-definition.controller.ts
@@ -6,7 +6,7 @@ import { UnauthorizedErrorDto } from 'apps/api-gateway/src/dtos/unauthorized-err
 import { ForbiddenErrorDto } from 'apps/api-gateway/src/dtos/forbidden-error.dto';
 import { User } from '../authz/decorators/user.decorator';
 import { AuthGuard } from '@nestjs/passport';
-import IResponseType from '@credebl/common/interfaces/response.interface';
+import IResponseType, { IResponse } from '@credebl/common/interfaces/response.interface';
 import { ResponseMessages } from '@credebl/common/response-messages';
 import { Response } from 'express';
 import { GetAllCredDefsDto } from './dto/get-all-cred-defs.dto';
@@ -128,14 +128,14 @@ export class CredentialDefinitionController {
     @Body() credDef: CreateCredentialDefinitionDto,
     @Param('orgId') orgId: string,
     @Res() res: Response
-  ): Promise<object> {
+  ): Promise<Response> {
 
     credDef.orgId = orgId;
     const credentialsDefinitionDetails = await this.credentialDefinitionService.createCredentialDefinition(credDef, user);
-    const credDefResponse: IResponseType = {
+    const credDefResponse: IResponse = {
       statusCode: HttpStatus.CREATED,
       message: ResponseMessages.credentialDefinition.success.create,
-      data: credentialsDefinitionDetails.response
+      data: credentialsDefinitionDetails
     };
     return res.status(HttpStatus.CREATED).json(credDefResponse);
   }
diff --git a/apps/api-gateway/src/credential-definition/credential-definition.service.ts b/apps/api-gateway/src/credential-definition/credential-definition.service.ts
index 86341899d..ec757f4ed 100644
--- a/apps/api-gateway/src/credential-definition/credential-definition.service.ts
+++ b/apps/api-gateway/src/credential-definition/credential-definition.service.ts
@@ -14,10 +14,10 @@ export class CredentialDefinitionService extends BaseService {
     super('CredentialDefinitionService');
   }
 
-  createCredentialDefinition(credDef: CreateCredentialDefinitionDto, user: IUserRequestInterface): Promise<{ response: object }> {
+  createCredentialDefinition(credDef: CreateCredentialDefinitionDto, user: IUserRequestInterface): Promise<object> {
     const payload = { credDef, user };
     
-    return this.sendNats(this.credDefServiceProxy, 'create-credential-definition', payload);
+    return this.sendNatsMessage(this.credDefServiceProxy, 'create-credential-definition', payload);
   }
 
   getCredentialDefinitionById(credentialDefinitionId: string, orgId: string): Promise<{ response: object }> {
diff --git a/apps/ledger/src/credential-definition/credential-definition.service.ts b/apps/ledger/src/credential-definition/credential-definition.service.ts
index 9364f6286..c68bfed2d 100644
--- a/apps/ledger/src/credential-definition/credential-definition.service.ts
+++ b/apps/ledger/src/credential-definition/credential-definition.service.ts
@@ -123,6 +123,10 @@ export class CredentialDefinitionService extends BaseService {
                 credDefData.lastChangedBy = userId;
             }
             const credDefResponse = await this.credentialDefinitionRepository.saveCredentialDefinition(credDefData);
+
+            delete credDefResponse.lastChangedBy;
+            delete credDefResponse.lastChangedDateTime;
+
             return credDefResponse;
 
         } catch (error) {