Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New lockfile format unsupported #288

Closed
Nemo157 opened this issue Feb 10, 2020 · 3 comments
Closed

New lockfile format unsupported #288

Nemo157 opened this issue Feb 10, 2020 · 3 comments

Comments

@Nemo157
Copy link
Contributor

Nemo157 commented Feb 10, 2020

Since Rust 1.41 the default lockfile format has been updated. This has been supported since Rust 1.38, but unfortunately cargo-crev is still using cargo v0.38 from Rust 1.37.

Trying to run cargo crev crate verify on a repo using the new format gives

> cargo crev crate verify
Error: failed to parse lock file at: /tmp/tmp.9Ks6bkSzKY/foo/Cargo.lock
  caused by: invalid serialized PackageId for key `package.dependencies`

This should just require updating the cargo dependency version (or switching to cargo-metadata if that provides enough details to get independence from the exact file format, and a reduced build time).

@CAD97
Copy link
Contributor

CAD97 commented Feb 10, 2020

I should note that this issue is preventing me from publishing reviews of my new crates; I can't even just use an older toolchain, because they require the trait coherence changes from 1.41.

@Nemo157
Copy link
Contributor Author

Nemo157 commented Feb 10, 2020

As a workaround for now you can use cargo-lock to translate back and forth between the formats.

@dpc
Copy link
Collaborator

dpc commented Feb 10, 2020

Anyone can try to bump the cargo dependency and submit a PR?

@dpc dpc closed this as completed in 38145bd Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants