Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consul_templaterb uses deprecated methods #90

Open
jlkiri opened this issue Dec 22, 2022 · 3 comments · May be fixed by #92
Open

consul_templaterb uses deprecated methods #90

jlkiri opened this issue Dec 22, 2022 · 3 comments · May be fixed by #92

Comments

@jlkiri
Copy link

jlkiri commented Dec 22, 2022

When I run consul_templaterb I get the following output in the terminal:

/usr/local/share/gems/gems/consul-templaterb-1.33.2/lib/consul/async/consul_template.rb:321: warning: Passing trim_mode with the 3rd argument of ERB.new is deprecated. Use keyword argument like ERB.new(str, trim_mode: ...) instead.
/usr/local/share/gems/gems/consul-templaterb-1.33.2/lib/consul/async/consul_template.rb:321: warning: Passing safe_level with the 2nd argument of ERB.new is deprecated. Do not use it, and specify other arguments as keyword arguments.
@pierresouchay
Copy link
Contributor

@jlkiri probably a new deprecation: what is your ruby version?

@jlkiri
Copy link
Author

jlkiri commented Dec 22, 2022

ruby 3.1.3p185 (2022-11-24 revision 1a6b16756e) [x86_64-linux]

@pierresouchay
Copy link
Contributor

@jlkiri Feel free to provide a patch, you only need to name the parameters at https://github.com/criteo/consul-templaterb/blob/master/lib/consul/async/consul_template.rb#L321

@jlkiri jlkiri linked a pull request Jan 1, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants