Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable tests on windows and macos ci platform #610

Open
Emilgardis opened this issue Nov 19, 2021 · 8 comments
Open

enable tests on windows and macos ci platform #610

Emilgardis opened this issue Nov 19, 2021 · 8 comments
Labels
enhancement meta issues/PRs related to the maintenance of the crate.

Comments

@Emilgardis
Copy link
Member

Emilgardis commented Nov 19, 2021

enable ci/tests.sh to run on ci for windows and macos

@Emilgardis Emilgardis changed the title enable tests on windows and macos platform enable tests on windows and macos ci platform Nov 19, 2021
@Emilgardis
Copy link
Member Author

This has been partially solved with #609, we still do not test cross with these images.

We should test every image we produce with Linux, Mac and Windows GHA runners.

@reitermarkus
Copy link
Member

we still do not test cross with these images.

We don't have images for these targets, so what is there to test?

@Emilgardis
Copy link
Member Author

We do, don't we? https://github.com/cross-rs/cross/pkgs/container/x86_64-pc-windows-gnu

As for testing, I mean tests to catch stuff like #461

@Emilgardis
Copy link
Member Author

Emilgardis commented Mar 20, 2022

I'm struggling with coming up with a satisfactory way to solve this.

Alt 1.

Artifact all images in docker-images and in a new action image-tests step that needs docker-images get all image artifacts, try a subset of those artifacts on windows, linux and macos on some example workspaces, and then on success run publish step which publishes the artifacted images etc.

Alt 2.

run scheduled task that tests current main images with windows/mac/linux on some example workspaces.

@Alexhuszagh
Copy link
Contributor

Alexhuszagh commented Jun 16, 2022

We could test for a single platform on macOS and Windows, build a single image fetched from cache (choose one unlikely to change for the best performance) and just install the latest cross and run from our cache?

We don't provide images for *-msvc or *-apple-*, so I think just testing CI works for an image we support on Windows and macOS is a good idea?

@Emilgardis
Copy link
Member Author

That should work, there is one thing to be careful of then however, changes that break mac/windows won't be catched if the conditions needed to break are not in the cached image.

@Alexhuszagh
Copy link
Contributor

That should work, there is one thing to be careful of then however, changes that break mac/windows won't be catched if the conditions needed to break are not in the cached image.

At least we'll catch them relatively early with the weekly update, so we can triage pretty quickly.

@Emilgardis
Copy link
Member Author

this will have to be implemented on self-hosted runners, see actions/runner-images#252 and actions/runner-images#2150

@Alexhuszagh Alexhuszagh added the meta issues/PRs related to the maintenance of the crate. label Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement meta issues/PRs related to the maintenance of the crate.
Projects
None yet
Development

No branches or pull requests

3 participants