-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable tests on windows and macos ci platform #610
Comments
This has been partially solved with #609, we still do not test cross with these images. We should test every image we produce with Linux, Mac and Windows GHA runners. |
We don't have images for these targets, so what is there to test? |
We do, don't we? https://github.com/cross-rs/cross/pkgs/container/x86_64-pc-windows-gnu As for testing, I mean tests to catch stuff like #461 |
I'm struggling with coming up with a satisfactory way to solve this. Alt 1. Artifact all images in Alt 2. run scheduled task that tests current main images with windows/mac/linux on some example workspaces. |
We could test for a single platform on macOS and Windows, build a single image fetched from cache (choose one unlikely to change for the best performance) and just install the latest cross and run from our cache? We don't provide images for |
That should work, there is one thing to be careful of then however, changes that break mac/windows won't be catched if the conditions needed to break are not in the cached image. |
At least we'll catch them relatively early with the weekly update, so we can triage pretty quickly. |
this will have to be implemented on self-hosted runners, see actions/runner-images#252 and actions/runner-images#2150 |
enable ci/tests.sh to run on ci for windows and macos
The text was updated successfully, but these errors were encountered: