-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ThreadSanitizer doesn't like crossbeam_deque? #589
Comments
I see a lot of tsan warning when running the
|
crossbeam-deque + TSan log here: https://gist.github.com/workingjubilee/ce78314bc2aa66ac1f563e6934ad28c0 |
This is likely tokio-rs/tokio#329 (comment)
crossbeam/crossbeam-deque/src/deque.rs Lines 63 to 81 in 220e690
|
For future explorers: this is still a problem, but it's fundamental to the design, so you really just need to suppress it as noted in the comment above. |
Not 100% sure if this is crossbeam's issue, or how rayon's using crossbeam, but filing the issue here as well (see rayon-rs/rayon#812)
I'm working on increasing the tsan coverage in firefox, and it appears that tsan doesn't understand whatever tricks you're using in crossbeam_deque.
If this design is relying on fences, it's a known issue that tsan doesn't work well with them. Although this is probably not a correctness issue, making crossbeam more tsan friendly would probably be good to do.
Firefox CI failure
Archived tsan backtrace
The text was updated successfully, but these errors were encountered: