Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status ignores unfinished upgrades #137

Open
ksawerykarwacki opened this issue Aug 16, 2022 · 3 comments
Open

Status ignores unfinished upgrades #137

ksawerykarwacki opened this issue Aug 16, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@ksawerykarwacki
Copy link

What happened?

When you change values or chart version sync/ready statuses stay True even before helm is upgraded. It means that there is no way to trace status on upgrades as helm provider does not change status so whole parent composition stays as Ready even if multiple charts are upgrading.

How can we reproduce it?

  1. Deploy helm chart using composition and passing values/version as composition parameter.
  2. Change values on composition/claim
  3. Observe status of composition/claim
@ksawerykarwacki ksawerykarwacki added the bug Something isn't working label Aug 16, 2022
@ksawerykarwacki ksawerykarwacki changed the title Status ignores unfinished upgrades. Status ignores unfinished upgrades Aug 16, 2022
@Rakhmanov
Copy link

Same issue when using directly release kind, after updating the status block reports condition of previous release. It is impossible to use kubectl wait --for=condition=complete as the command will instantly return with the completion from previous release.

Even programmatically there are not enough data in the type Release to know if new version is successful.
As the revision number in the status only gets updated when it reached some state on the helm side, which takes time.
Possible solution is to reset the status on new version sync.

@ksawerykarwacki
Copy link
Author

@Rakhmanov that would be also my preferred solution. To keep sync set to true and set ready to false until release finishes deploying.

@ksawerykarwacki
Copy link
Author

@turkenh any chance to fix that? It is impossible to trace updates currently without some hacky way to trace revision hash as part of connection secret. Reset of ready condition to false seems to be sufficient for most of the cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants