add crossplane-external-name tag to external resources #409
Conversation
Signed-off-by: Lucas Caparelli <[email protected]>
LCaparelli
requested review from
ulucinar,
sergenyalcin,
erhancagirici and
mergenci
as code owners
|
In order to make my fork work, I had to manually assign RBAC permissions to the generated ServiceAccount: rules:
- apiGroups:
- aws.upbound.io
resources:
- providerconfigs
- providerconfigs/status
- providerconfigusages
- providerconfigusages/status
- storeconfigs
- storeconfigs/status
verbs:
- '*'I think it might be because I only built the EC2 provider, and not the entire family. Honestly I'm not sure. I don't see how this change could interfere with that, so I'm guessing this is unrelated, but appreciate any pointers. |
| const externalResourceTagKeyExternalName = "crossplane-external-name" | ||
|
|
||
| func getExternalTags(mg xpresource.Managed) map[string]string { | ||
| externalTags := xpresource.GetExternalTags(mg) |
There was a problem hiding this comment.
This was the only call to xpresource.GetExternalTags I could find in the code, so I'm assuming this is the best and only place to provide this additional tag. If there are other places I'm missing, please let me know and I'll adjust.
|
Hi @LCaparelli, |
|
@ulucinar feel free to checkout the recording of @LCaparelli presenting on this topic: #408 (comment) |
|
@ulucinar I added/suggested a discussion topic to SIG Upjet's meeting backlog |
Description of your changes
Ensures a new tag containing the value set to the external-name annotation exists in external resources.
Fixes #408
I kinda didn't wait for discussion to pan out on the issue, and I understand if this is not at all the direction we want to take. Just thought it'd be nice to present a problem along with a possible solution. If you have concerns about the direction, please feel free to chime in at the issue or ping me directly on Crossplane's Slack.
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
I have pulled provider-aws-upjet locally, checked out at the v1.5.0 tag, pointed the dependency to this branch using go.mod replace, built the EC2 provider and deployed it in our development environments. All EC2 managed resources now have this additional tag.