Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: no integration test for acknowledgement of ibc/gravity-bridge token transfer #398

Closed
yihuang opened this issue Mar 17, 2022 · 2 comments
Closed

Problem: no integration test for acknowledgement of ibc/gravity-bridge token transfer #398

yihuang opened this issue Mar 17, 2022 · 2 comments
Assignees
@macong-cdc
Labels
gravity bridge This issue or pull request is related to the Gravity Bridge functionality tests This issue is related to unit or integration tests

Comments

@yihuang
Copy link
Collaborator

yihuang commented Mar 17, 2022 •
edited
Loading

test the tokens are refunded if the receiver side failed or timeout for send_to_ethereum/send_to_ibc.
@yihuang yihuang added tests This issue is related to unit or integration tests gravity bridge This issue or pull request is related to the Gravity Bridge functionality labels May 19, 2022
@thomas-nguy
Copy link
Collaborator

I think there is no concept of timeout for send_to_ethereum. Means that this operation is irreversible.

It is possible to cancel if the transaction is not included in a batch, but the current way is not ideal because batch are created every x blocks, so it is very hard to be able to cancel on time

@tomtau tomtau mentioned this issue May 27, 2022
Closed
@tomtau tomtau assigned macong-cdc and unassigned linfeng-crypto May 31, 2022
@yihuang
Copy link
Collaborator Author

yihuang commented Aug 18, 2022

failed ack scenarios are tested both for ibc and gravity-bridge now.

@yihuang yihuang closed this as completed Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@macong-cdc macong-cdc

Labels
gravity bridge This issue or pull request is related to the Gravity Bridge functionality tests This issue is related to unit or integration tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@yihuang @linfeng-crypto @thomas-nguy @macong-cdc