Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: no command to patch gasUsed in pior-v0.7 blocks #792

Closed
yihuang opened this issue Dec 15, 2022 · 2 comments
Closed

Problem: no command to patch gasUsed in pior-v0.7 blocks #792

yihuang opened this issue Dec 15, 2022 · 2 comments

Comments

@yihuang
Copy link
Collaborator

yihuang commented Dec 15, 2022 •
edited
Loading

Before v0.7.0 upgrade, due to this bug, the reverted tx get charged full gas limit, so the reported gasUsed don't match the deducted fee, it confuse some clients, better to patch the tx results to change the gasUsed to gasLimit.

Alternatively:

  • we can patch the rpc endpoints logic somehow.
  • client just track the fee_collector flows for actual fee deducted.
@mmsqe
Copy link
Collaborator

mmsqe commented Dec 15, 2022

option 1 is only patch in rpc api instead of tm db right?

@yihuang
Copy link
Collaborator Author

yihuang commented Dec 15, 2022

option 1 is only patch in rpc api instead of tm db right?

yes

@mmsqe mmsqe mentioned this issue Dec 16, 2022
Merged
11 tasks
@mmsqe mmsqe closed this as completed Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yihuang @mmsqe and others