New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: tendermint dependency is not removed #224

Open

thomas-nguy opened this issue Mar 31, 2023 · 0 comments

Collaborator

thomas-nguy commented Mar 31, 2023

Tendermint dependency is still used there

https://github.com/crypto-org-chain/gravity-bridge/blob/v2.0.0-cronos/module/go.mod#L26

Main reason is that the migration folder (https://github.com/crypto-org-chain/gravity-bridge/tree/v2.0.0-cronos/module/x/gravity/migrations/v1) are keeping the old type from v1 to perform some tests.

Since v1 version has never been used, we can safely remove those tests

thomas-nguy changed the title ~~Problem: Remove tendermint dependency~~ Problem: tendermint dependency is not removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment