Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

privateKeyModInverse not exported anymore #198

Closed
vostrnad opened this issue Jul 24, 2023 · 2 comments
Closed

privateKeyModInverse not exported anymore #198

vostrnad opened this issue Jul 24, 2023 · 2 comments

Comments

@vostrnad
Copy link

It seems the function privateKeyModInverse was removed in #160 without explanation (as far as I can tell). Was that intentional? Can we have it back?
@fanatid
Copy link
Member

fanatid commented Jul 24, 2023

ouch, it's bad that we removed it without a note about this in the pull request
bitcoin-core/secp256k1 do not export this function, I'm not sure that we need to implement it by ourselves 😕 https://github.com/bitcoin-core/secp256k1/blob/d644dda5c9dbdecee52d1aa259235510fdc2d4ee/include/secp256k1.h

@vostrnad
Copy link
Author

Thank you for the response, I guess you can just amend the release note for v4.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fanatid @vostrnad