Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slither error doesn't cause a job failure #2600

Open
oscarsernarosero opened this issue Nov 1, 2024 · 0 comments
Open

Slither error doesn't cause a job failure #2600

oscarsernarosero opened this issue Nov 1, 2024 · 0 comments

Comments

@oscarsernarosero
Copy link

If Slither detectors are not opened or closed properly, Slither throws an error indicating that there might be a dangerous misconfiguration. These kind of errors, however, are not caught by the job which fails silently as there is no fail-on option for error.

Example:
close a detector that hasn't been started (i.e.slither-disable-end). The job passes, but the logs show

ERROR:Slither:slither-disable-end without slither-disable-start
@elopez elopez transferred this issue from crytic/slither-action Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant