Skip to content
This repository has been archived by the owner on Mar 13, 2020. It is now read-only.

Does not detect Objects correctly #5

Open
marcoancona opened this issue Jun 27, 2018 · 0 comments
Open

Does not detect Objects correctly #5

marcoancona opened this issue Jun 27, 2018 · 0 comments

Comments

@marcoancona
Copy link

marcoancona commented Jun 27, 2018

Cool project, exactly what I was looking for.
I notice one problem. When using immutable=False the function is_object(ref) is called to check whether the element is an Object in order to force the update.
The function, however, returns several false negatives as ref.constructor === Object evaluates to false for several objects. Why not keep only return ref instanceof Object ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant