Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building from source fails #2675

Closed
nilsocket opened this issue Mar 25, 2022 · 7 comments
Closed

Building from source fails #2675

nilsocket opened this issue Mar 25, 2022 · 7 comments

Comments

@nilsocket
Copy link

nilsocket commented Mar 25, 2022

go version: 1.18
Linux nil 5.10.105-1-MANJARO #1 SMP PREEMPT Fri Mar 11 14:12:33 UTC 2022 x86_64 GNU/Linux

on make deps
I get error: go get doesn't work outside of a module for goimports
With a temporary fix of using go install x.com/goimports@latest

Next,
on make build
I get error: missing go.sum entry for golang.org/x/text/...
with a temporary fix of running go get the above package names

Thank you.

@wkloucek
Copy link
Contributor

I'm also on Manjaro, but still on go version go1.17.8 linux/amd64.

go mod tidy also fails for me.

Could you try to run go run ./cmd/revad? That's the actual reva server you want to run. It will report that you're missing a config.

You can choose a config from the examples directory by running go run ./cmd/revad -dev-dir examples/xxx

@redblom
Copy link
Contributor

redblom commented Apr 4, 2022

I'm using the provided Docker setup (which uses go version 1.17.3) and can also confirm that make dep fails.
Using go install golang.org/x/tools/cmd/goimports@latest works and then (after make build) I can start the server without further issues (with the proper config of course :)

@KarthikSundar2002
Copy link
Contributor

KarthikSundar2002 commented Apr 16, 2022

This issue arises due to the fact that the Makefile is outdated, I can make a PR with the correct Makefile. After fixing the Makefile, things seem to work fine.

@pascalwengerter
Copy link
Contributor

This issue arises due to the fact that the Makefile is outdated, I can make a PR with the correct Makefile. After fixing the Makefile, things seem to work fine.

Feel free to open a PR, of course! :)

@KarthikSundar2002
Copy link
Contributor

I have opened a PR #2747 with the changes.

@KarthikSundar2002
Copy link
Contributor

Now that my PR is merged, I guess this issue can be closed after verifying

@ishank011
Copy link
Contributor

Fixed by #2747

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants