Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce the new cs3-python-client library #161

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Introduce the new cs3-python-client library #161

wants to merge 13 commits into from

Conversation

glpatcern
Copy link
Member

@glpatcern glpatcern commented Aug 10, 2024 •
edited
Loading

This PR is to introduce the https://github.com/cs3org/cs3-python-client library contributed by @rawe0.

As part of this, some refactoring and simplification has taken place:

  • Simplified xattrs handling: dropped the need for an independent getxattr() API, as well as the caching recently introduced, as the xattrs are always queried next to a stat call.
  • Removed versioninv flag on stat, assuming it's always version invariant. Only xroot was able to make a distinction.
  • Standardized readfile that now raises an exception instead of yielding it. Consequently dropped the peek logic.
  • Standardized error messages.

@micbar a heads-up about a larger-than-usual change.

Remaining tasks:

  • Push cs3client >= 1.1 as requirement
  • Test with the Microsoft WOPI validator

@glpatcern glpatcern marked this pull request as draft August 10, 2024 14:52
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 10, 2024
View reviewed changes
src/core/localiface.py Fixed Show fixed Hide fixed
@glpatcern glpatcern force-pushed the cs3client branch 4 times, most recently from 64d3962 to a8217ef Compare August 10, 2024 15:20
@glpatcern glpatcern linked an issue Aug 30, 2024 that may be closed by this pull request
Rerfactor logic to get rid of get_xattr calls #158
Open
@glpatcern glpatcern marked this pull request as ready for review August 30, 2024 15:14
@glpatcern glpatcern changed the title WIP to use the new cs3-python-client library Introduce the new cs3-python-client library Aug 30, 2024
@glpatcern
Copy link
Member Author

Marking as ready for review given that the code is pretty much complete. Once the build passes, we can review and merge this change.

@glpatcern glpatcern marked this pull request as draft September 6, 2024 07:08
@glpatcern
Copy link
Member Author

glpatcern commented Sep 6, 2024 •
edited
Loading

Remaining developments:

  • convert the code dealing with yielded exceptions from readfile(), now that the function can raise them.
  • rename exception messages (ENOENT goes into the cs3 library, EXCL_ERROR gets replaced from the library)
  • get rid of versioninv

@glpatcern glpatcern mentioned this pull request Sep 13, 2024
Merged
@glpatcern
Copy link
Member Author

Following cs3org/cs3-python-client#8 we now pass the whole test suite:

$ pytest-3
============================== test session starts ===============================
platform linux -- Python 3.9.18, pytest-6.2.2, py-1.10.0, pluggy-0.13.1
rootdir: /root/WOPI
collected 20 items

test/test_storageiface.py
....................                                                                                [100%]

Therefore this is ready to review.

@glpatcern glpatcern marked this pull request as ready for review September 13, 2024 14:11
@glpatcern glpatcern marked this pull request as draft September 24, 2024 15:47
@glpatcern glpatcern marked this pull request as ready for review November 5, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diocas diocas Awaiting requested review from diocas

At least 1 approving review is required to merge this pull request.

Assignees

@rawe0 rawe0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rerfactor logic to get rid of get_xattr calls
2 participants
@glpatcern @rawe0