Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend test suite to cover expired locks #66

Closed
glpatcern opened this issue Mar 4, 2022 · 1 comment
Closed

Extend test suite to cover expired locks #66

glpatcern opened this issue Mar 4, 2022 · 1 comment
Labels

Comments

@glpatcern
Copy link
Member

The idea here is to create a short-living lock and get it back / refresh it after it expired, to exercise this part of the logic.

Should be pretty easy with local storage, though the code as of now does NOT validate the expiration time. The real interest though is to run this test against Reva, once #57 is completed.

@glpatcern glpatcern added the CI label Mar 4, 2022
@glpatcern
Copy link
Member Author

With more thoughts, for the time being the Lock API shall return expired locks and shall not infer anything, so in terms of test suite nothing would change. The WOPI server business logic handles expiration internally.

@glpatcern glpatcern reopened this Apr 25, 2023
@glpatcern glpatcern closed this as not planned Won't fix, can't repro, duplicate, stale Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant