-
Notifications
You must be signed in to change notification settings - Fork 90
Unknown word: 7.0.0 fails with inlined base64 svg #224
Comments
Thank you for reporting this! It looks like a css-values-parser message. Can you add the surrounding css so that we can add a test and pinpoint the cause? for example : .foo {
background: url('data:image/svg+xml;base64,PD94bWwgdmVy...');
} Can you also try quoting the data string? It might surface now when upgrading |
Sure! thanks for taking a look! My real situation was a large file from a package (built by vite) and imported from node_modules. But to isolate it, I did test
Again, the original file is built by vite so I can't really add the quotes myself (the data url is indeed unquoted though). I can test if that does solve it and report the issue in the vite repo. Thanks for pointing out the postcss-values-parser issue. Will keep an eye on it. |
I think it would also be safest if we update all plugins using They could still be emitted as warnings but shouldn't break builds. |
@pau-santesmasses we've just released a new version (7.0.1) that hopefully fixes your issue entirely. If you could try that'd be great. We've tested internally but can't be 100% sure without all of your code. |
@Antonio-Laguna it works now. Thank you! |
@pau-santesmasses That is correct. For example An improvement on this would be to correctly parse unquoted data urls. |
Closing as it's confirmed to be fixed :) |
Documenting in case others run across this issue. After updating from 6.7.0 to 7.0.1 my builds began to hang. I was able to trace the problem back to some lines that use postcss-inline-svg. Here is an example:
I was able to get around the problem by adding quotes around the stroke color: The fix was easy enough, but the documentation for postcss-inline-svg does not include the quotes. I imagine others will run into this same issue. |
@mrockwood Can you open a new issue for your case so that we can track this down? |
@romainmenke I feel this will probably go away with all the things we've been doing lately but it'll be good to test this for sure |
Error message:
Didn't seem to be a problem on 6.7.0. Removing the data url or replacing the base64 with the actual svg makes it work again..
The text was updated successfully, but these errors were encountered: