Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concentration features are calculated on all pixels, not just the ones that survive cleaning #580

Closed
maxnoe opened this issue Jan 11, 2021 · 3 comments
Labels
good first issue Good for newcomers

Comments

@maxnoe
Copy link
Member

maxnoe commented Jan 11, 2021

I don't know if it's worth to change this before switching to ctapipe-stage1.

@rlopezcoto
Copy link
Contributor

should be a very quick change in case we make another release before definitely moving to ctapipe-stage1, right?

@maxnoe maxnoe added the good first issue Good for newcomers label Jan 17, 2022
@maxnoe maxnoe assigned maxnoe and unassigned maxnoe Jan 21, 2022
@moralejo
Copy link
Collaborator

It is worth to fix it straightaway - let's see is some newcomer decides to take it.
Still, only concentration_pixel is affected, and even that one is affected only for events in which the brightest pixel in the camera did not survive the cleaning. So it will not make a large difference.

@maxnoe
Copy link
Member Author

maxnoe commented Jan 21, 2022

You are right, since concentration is using the hillas intensity internally. I thought it sums the image again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants