Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DL1 Data Processing Tool #1066

Closed
16 of 17 tasks
kosack opened this issue May 2, 2019 · 2 comments
Closed
16 of 17 tasks

DL1 Data Processing Tool #1066

kosack opened this issue May 2, 2019 · 2 comments

Comments

@kosack
Copy link
Contributor

kosack commented May 2, 2019

This is a "parent" issue to track some developments needed to implement proper DL1 data handling in ctapipe. This is part of a larger issue to make a standard chain (See #977)

Assumptions:

  • DL1 data are in HDF5 format
  • development should be synchronized to the protopipe development (the final Tool should replace the protopipe dl1 script, dl1-data-handler, and optionally later also the lstchain dl1 script, if that is useful)

Tasks:

  • refactor basic image calibration code (see Major refactoring of calibration chain #1026 )
  • Do gain-selection during or after calibration and charge extraction (so that we have only a single DL1 image), (See Major refactoring of calibration chain #1026, additional tasks)
  • Decide on DL1 file format/layout: (discussion: DL1 data file layout discussion #1059 )
  • Implement writing SubarrayDescription to an HDF5 file
  • Implement creating a SubarrayDescription from an HDF5 file (written with prev step)
  • Implement standard ctapipe DL0 -> DL1 Tool (based on protopipe, lstchain, dl1-dumper, etc)
    • Metadata tables:
      • simulation run configuration
      • observation configuration
    • Event tables:
      • monte-carlo events table
      • trigger table
      • standard calibrated image tables (easy, just needs calib)
      • standard image parameter tables (requires image processing chain and configuration thereof)
    • Monitoring tables (lower priority for now, but needed later)
      • pointing correction table
      • calibration monitoring (see implementation in LSTCamEventSource for example)
  • Implement a DL1EventSource that reads output from the DL1 tool described in prev step so that a DL2 tool can also be created.
  • Ensure the DL1 tool can be configured by a user (via config file and command-line) and that the input and output configuration is tracked and stored in the provenance metadata (see Improvements to Tool and Component functionality #1052)
  • store full provenance metadata in output file
@kosack
Copy link
Contributor Author

kosack commented Aug 30, 2019

Just to note, I've made big progress on this and have a prototype working. During its development, i found a number of small bugs or missing features in ctapipe, so I will first start (in the next week or so) to create pull requests for those changes before committing the full tool.

@kosack
Copy link
Contributor Author

kosack commented May 21, 2020

I will close this, since it's all implemented (except for a DL1EventSource, but that can be a separate issue)

@kosack kosack closed this as completed May 21, 2020
@maxnoe maxnoe unpinned this issue Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants